[linux-dvb] [PATCH] lgdt330x: SNR and signal strength reporting

Michael Krufky mkrufky at linuxtv.org
Mon Oct 30 20:50:47 CET 2006


Patrick Boettcher wrote:
> Hi,
> 
> On Sun, 29 Oct 2006, Michael Krufky wrote:
>> I'm posting this to the list for final review before requesting merge into master.
> 
> You get what you've asked for:
> 
>> +/* Use Equalizer Mean Sqaured Error instead of Phaser Tracker MSE */
>                          ^^^^^^^
> Squared?

typo corrected... thanks.

> 
>> +		/* Negative SNR, which is possible, but realisticly the
>> +		demod will lose lock before the signal gets this bad.  The
>> +		API only allows for unsigned values, so just return 0 */
> 
> In DVB-T QPSK FEC 1/2 it is possible to receive while having a negative 
> SNR.

OK, but still the API expects an unsigned integer... This was more of a
"point-of-information" than a critique, right?

Unless anybody has any more issues with this patch, I will ask Mauro to
merge it from my tree: http://linuxtv.org/hg/~mkrufky/lgdt330x

Cheers,

Michael Krufky




More information about the linux-dvb mailing list