[linux-dvb] [PATCH] mt312: coding style improvements

Matthias Schwarzott zzam at gentoo.org
Fri Dec 21 14:17:14 CET 2007


On Freitag, 21. Dezember 2007, Mauro Carvalho Chehab wrote:
>
> Less relevant CodingStyle problems are marked as WARNING. As this is an
> "ERROR", seems good to fix.
>
> In the above case, the code is still not so bad, but there are some
> constructions that look worse, like:
>
> if ((ret=foo())) {
> 	bar;
> }
>
Yeah - really looks worse.

> (I found this kind of construction on some code I've touched recently on
> V4L)
>
> While this would be good to fix, I don't see any need for rushing it.
>
As you tell fixing is good. Then I can post the patch now, as I am doing more 
changes on mt312.c it will help to get easy things done and commited first.

Matthias

-- 
Matthias Schwarzott (zzam)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mt312_assignment_in_if.diff
Type: text/x-diff
Size: 9523 bytes
Desc: not available
Url : http://www.linuxtv.org/pipermail/linux-dvb/attachments/20071221/1f10f95c/attachment-0001.diff 


More information about the linux-dvb mailing list