[linux-dvb] [PATCH] dvb-core: Fix several locking related problems.

Andreas Oberritter obi at linuxtv.org
Sat Feb 24 19:48:38 CET 2007


Hi Simon,

Simon Arlott wrote:
> @@ -673,13 +672,8 @@ static int dvb_demux_open(struct inode *
>  static int dvb_dmxdev_filter_free(struct dmxdev *dmxdev,
>  				  struct dmxdev_filter *dmxdevfilter)
>  {
> -	if (mutex_lock_interruptible(&dmxdev->mutex))
> -		return -ERESTARTSYS;
> -
> -	if (mutex_lock_interruptible(&dmxdevfilter->mutex)) {
> -		mutex_unlock(&dmxdev->mutex);
> -		return -ERESTARTSYS;
> -	}
> +	mutex_lock(&dmxdev->mutex);
> +	mutex_lock_interruptible(&dmxdevfilter->mutex);

Assuming that the rest of the patch is OK, shouldn't this be a
mutex_lock(), too, if the return value will be ignored?

Regards,
Andreas

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: OpenPGP digital signature
Url : http://www.linuxtv.org/pipermail/linux-dvb/attachments/20070224/e223b845/signature.pgp


More information about the linux-dvb mailing list