[linux-dvb] [v4l-dvb-maintainer] [PULL] minor videobuf fixes http://ifup.org/hg/v4l-dvb

hermann pitton hermann-pitton at arcor.de
Wed Nov 14 05:27:37 CET 2007


Hi!

Am Dienstag, den 13.11.2007, 15:44 -0800 schrieb Brandon Philips:
> Hello Mauro,
> 
> Please review and pull from http://ifup.org/hg/v4l-dvb for:

Brandon, that above link is dead for me.

Likely not related to all what you try to fix currently, maybe I have to
read the recent patch policy again, but stuff coming in off lists is bad
anyway.

I'm against that possible major changes happen without being visible to
the public. That goes also for more complex down ports from kernel.
Finally someone with restricted abilities, like me, for global testing
nobody is able to do it alone,  should confirm that such changes are
functional in the end after they already happened or are assumed to be
harmless.

Since next _improvements_ will for sure come soon, there are already
complaints for example that NICAM stereo on PAL_DK is broken on the
saa7134 driver, which I happily ignore too, since it is only one voice.
But fact is, that we mostly have only _one_ voice over a _very long_
time period and others can't test ...

I don't understand, why patches have no equivalent on the public lists
anymore, yeah, for a finally payed distro it looks better, 
but to have them public is also very important for to get new interested
people in the long run.

To make it short, not caused by you at all, _all_ patches have to be on
the lists again and nothing else is acceptable, that I vote for.

To claim it is enough to review them when they arrive at kernel, is
proved to be wrong. Adrian and others will do their best, but the bang
always still comes thereafter.

That means also that major patch bombs should be send again at least
every three months, to face against that it is politics to deny them,
when in truth it are only the limited resources to review them.

Cheers,
Hermann

 
> 
> - V4L: videobuf: don't chew up namespace STATE_.*, convert to VIDEOBUF_
> - V4L: videobuf: convert streaming and reading to bitfields
> - V4L: videobuf-core locking fixes and comments
> - V4L: Convert videobuf drivers to videobuf_stop
> 
>  b/linux/drivers/media/common/saa7146_fops.c           |    8 
>  b/linux/drivers/media/common/saa7146_vbi.c            |   10 
>  b/linux/drivers/media/common/saa7146_video.c          |    8 
>  b/linux/drivers/media/video/bt8xx/bttv-driver.c       |   26 -
>  b/linux/drivers/media/video/bt8xx/bttv-risc.c         |   14 
>  b/linux/drivers/media/video/bt8xx/bttv-vbi.c          |    6 
>  b/linux/drivers/media/video/cx23885/cx23885-core.c    |   18 
>  b/linux/drivers/media/video/cx88/cx88-alsa.c          |    2 
>  b/linux/drivers/media/video/cx88/cx88-blackbird.c     |    5 
>  b/linux/drivers/media/video/cx88/cx88-core.c          |    4 
>  b/linux/drivers/media/video/cx88/cx88-mpeg.c          |   14 
>  b/linux/drivers/media/video/cx88/cx88-vbi.c           |   10 
>  b/linux/drivers/media/video/cx88/cx88-video.c         |   22 
>  b/linux/drivers/media/video/saa7134/saa7134-core.c    |    8 
>  b/linux/drivers/media/video/saa7134/saa7134-empress.c |    5 
>  b/linux/drivers/media/video/saa7134/saa7134-ts.c      |    8 
>  b/linux/drivers/media/video/saa7134/saa7134-vbi.c     |    8 
>  b/linux/drivers/media/video/saa7134/saa7134-video.c   |   12 
>  b/linux/drivers/media/video/videobuf-core.c           |   50 +-
>  b/linux/drivers/media/video/videobuf-dvb.c            |    2 
>  b/linux/drivers/media/video/vivi.c                    |   24 
>  b/linux/include/media/videobuf-core.h                 |   14 
>  linux/drivers/media/common/saa7146_video.c            |    5 
>  linux/drivers/media/video/bt8xx/bttv-driver.c         |    5 
>  linux/drivers/media/video/cx88/cx88-video.c           |    5 
>  linux/drivers/media/video/saa7134/saa7134-video.c     |    5 
>  linux/drivers/media/video/videobuf-core.c             |  249 ++++++----
>  linux/drivers/media/video/vivi.c                      |    1 
>  linux/include/media/videobuf-core.h                   |    6 
>  29 files changed, 304 insertions(+), 250 deletions(-)
> 
> Thanks,
> 
> 	Brandon
> 
> _______________________________________________





More information about the linux-dvb mailing list