[linux-dvb] [PATCH] tda1004x driver has code to support HIERARCHY_AUTO, but does not set FE_CAN_HIERARCHY_AUTO

Simon Farnsworth simon.farnsworth at onelan.co.uk
Tue Sep 18 11:13:54 CEST 2007


Hello,

I've noticed that the tda1004x driver has code that appears to support
the use of HIERARCHY_AUTO, but it does not set FE_CAN_HIERARCHY_AUTO. In
particular, at around line 720 of tda1004x.c (in tda1004x_set_fe), we
have the following code:

// Set standard params.. or put them to auto
if ((fe_params->u.ofdm.code_rate_HP == FEC_AUTO) ||
	(fe_params->u.ofdm.code_rate_LP == FEC_AUTO) ||
	(fe_params->u.ofdm.constellation == QAM_AUTO) ||
	(fe_params->u.ofdm.hierarchy_information == HIERARCHY_AUTO)) {

The attached patch (compile-tested) sets FE_CAN_HIERARCHY_AUTO in the
tda1004x driver.

Signed-off-by: Simon Farnsworth <simon.farnsworth at onelan.co.uk>
---
I have no datasheet for the tda10046, so I don't know whether the code
is right, or the caps setting was right. I'm assuming the caps setting
is wrong, since the driver works with HIERARCHY_AUTO and has code to
support it; however, none of the muxes I can receive use hierarchical
coding.
-- 
Simon Farnsworth

-------------- next part --------------
A non-text attachment was scrubbed...
Name: tda1004x.can_hierarchy_auto.diff
Type: text/x-patch
Size: 599 bytes
Desc: not available
Url : http://www.linuxtv.org/pipermail/linux-dvb/attachments/20070918/bef141db/attachment.bin 


More information about the linux-dvb mailing list