[linux-dvb] [PATCH] 2/3: implement DMX_SET_BUFFER_SIZE for dvr

Oliver Endriss o.endriss at gmx.de
Mon Apr 14 01:50:22 CEST 2008


Andrea wrote:
> Andrea wrote:
> > Ok.
> > 
> > I've changed the second patch to
> > 1) allocate the new buffer before releasing the old one
> > 2) use spin_[un]lock_irq
> > 
> > 3) On top of that, I have rearranged the code of DMX_SET_BUFFER_SIZE for 
> > the demux so that it does the same as the dvr (i.e. allocate the new 
> > buffer before releasing the old one). I think it is a good idea that 2 
> > very similar functions are implemented in the same way. (if you don't 
> > agree, or if you think a 3rd separate patch for this point is a better 
> > idea, let me know.)
> > 
> > PS: Both patches 1/3 and 2/3 are against a clean v4l-dvb tree. I do not 
> > know how to generate incremental patch for 2/3.
> > 
> > Let me know what you think about that.
> > 
> > Andrea
> 
> I've fixed the patch to pass the "make checkpatch" check.
> 
> Andrea

Thanks. Afaics both patches look ok.

I'll sort out that incremental issue when I commit them.
If nobody complains I will do the check-in next weekend.

Please sign your patches. See README.patches for more information.
You can do this by replying to this thread with a message which contains
your 'Signed-off-by:'. Sorry for that. :-(

CU
Oliver

-- 
----------------------------------------------------------------
VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/
----------------------------------------------------------------



More information about the linux-dvb mailing list