[linux-dvb] Hauppauge WinTV regreession from 2.6.24 to 2.6.25
mkrufky at linuxtv.org
mkrufky at linuxtv.org
Fri Apr 25 17:06:57 CEST 2008
Mauro Carvalho Chehab wrote:
> On Fri, 25 Apr 2008 10:40:14 -0400
> "Michael Krufky" <mkrufky at linuxtv.org> wrote:
>> On Fri, Apr 25, 2008 at 9:56 AM, Mauro Carvalho Chehab
>> <mchehab at infradead.org> wrote:
>>> On Thu, 24 Apr 2008 05:55:28 +0200
>>> hermann pitton <hermann-pitton at arcor.de> wrote:
>>> > > > >>>> I am testing a kernel upgrade from 2.6.24.to 2.6.25, and the
>>> > > > >>>> for the Hauppauge WinTV appear to have suffered some
>>> > > > >>>> between the two kernel versions.
>>>> do you see the auto detection issue?
>>> > Either tell it is just nothing, what I very seriously doubt, or
>>> > comment.
>>> > I don't like to end up on LKML again getting told that written rules
>>> > don't exist ;)
>>> Sorry for now answer earlier. Too busy here, due to the merge window.
>>> This seems to be an old bug. On several cases, tuner_type information
>>> some sort of autodetection schema, but the proper setup is not sent to
>>> Please test the enclosed patch. It warrants that TUNER_SET_TYPE_ADDR is
>>> at saa7134_board_init2() for all those boards:
>>> It is important to test the above boards, to be sure that no regression
>>> Signed-off-by: Mauro Carvalho Chehab <mchehab at infradead.org>
>>> diff -r 60110897e86a linux/drivers/media/video/saa7134/saa7134-cards.c
>>> --- a/linux/drivers/media/video/saa7134/saa7134-cards.c Fri Apr 25
08:04:54 2008 -0300
>>> +++ b/linux/drivers/media/video/saa7134/saa7134-cards.c Fri Apr 25
10:44:16 2008 -0300
>> I didn't review your patch yet, and it needs to be tested, however,
>> the bug reported in this thread deals with the same regression that
>> you are attempting to repair, but on the cx88 driver -- not the
>> saa7134 driver.
> Hmm... it seems that people merged two similar issues together, on
> drivers. At least, part of the reports at the thread were with saa7134
> I'll investigate if this solution will also work for cx88.
"...people merged two similar issues together, on different drivers..."
It was you -- did you forget?
I'm surprised that you don't remember this -- you pushed this to Linus
late in the 2.6.25-rcX, after I had strongly advised against this -- I
warned you that this may create regressions, needed thorough testing,
and was too risky a change to push into the middle of 2.6.25-rc
I hate to say, "I told you so" .... but.............
Lets get your fixes tested ASAP so we can fix 2.6.25-stable.
More information about the linux-dvb