[linux-dvb] saa7134-dvb: add missing dvb_attach call (for tda10046_attach)

hermann pitton hermann-pitton at arcor.de
Sat Jan 26 02:52:10 CET 2008


Am Samstag, den 26.01.2008, 00:13 +0100 schrieb Hartmut Hackmann:
> Hi,
> 
> Matthias Schwarzott schrieb:
> > Hi there!
> > The attached small patch adds a missing dvb_attach wrapping around 
> > tda10046_attach.
> > So it removes the hard dependency of saa7134-dvb on tda1004x module.
> > 
> > I have only tested compiling as I don not have the hardware.
> > 
> > Greetings
> > Matthias
> > 
> > 
> I don't have this hardware either but your patch is right.
> Can you please resend it with your signature like
> 
> Signed-off-by: Hartmut Hackmann <hartmut.hackmann at t-online.de>
Reviewed-by: Hermann Pitton <hermann-pitton at arcor.de>

> (of corse with your name and e-mail address)
> 
> Please do this soon otherwise it will not make it into the next
> kernel release.
> 
> Best regards
>   Hartmut
> 

Hi all,

quality control is a nice thing.

To have a two weeks merge window too ... ;)

On checkpatch.pl and other stuff one can easily triple the total amount
of patches for nothing. On missing SOBs the amount of mails too.

We should carefully watch this.

It will end up in that only those buying new cards endlessly, hundreds
are already on the way, are trusted for patches.

Hm, that was not the plan for /me.

Cheers,
Hermann









More information about the linux-dvb mailing list