[linux-dvb] saa7134-dvb: add missing dvb_attach call (for tda10046_attach)

Trent Piepho xyzzy at speakeasy.org
Sat Jan 26 03:34:31 CET 2008


On Sat, 26 Jan 2008, Hartmut Hackmann wrote:
> Matthias Schwarzott schrieb:
> > Hi there!
> > The attached small patch adds a missing dvb_attach wrapping around
> > tda10046_attach.
> > So it removes the hard dependency of saa7134-dvb on tda1004x module.
> >
> > I have only tested compiling as I don not have the hardware.
> >
> I don't have this hardware either but your patch is right.
> Can you please resend it with your signature like

The lack of the dvb_attach() was probably a bug.  An attach must be matched
be a detach when the device is removed.  If they're unbalanced, you end up
with messed up module use counts and modules that can't be un-loaded.
There was probably already a detach, since all the other cards already used
dvb_attach().



More information about the linux-dvb mailing list