[linux-dvb] [PATCH] Shrink saa7134 mmio mapped size

hermann pitton hermann-pitton at arcor.de
Wed Jul 2 22:39:35 CEST 2008


Hello,

Am Mittwoch, den 02.07.2008, 16:50 +0100 schrieb Andy Burns:
> The saa7134 driver attempts to map a fixed 4K starting from the base 
> address of its mmio area, regardless of the actual size of the area.
> Any excessive mapping may extend past the end of a page, which goes 
> un-noticed on bare-metal, but is detected and denied when the card is 
> used with pci passthrough to a xen domU. If shared IRQ is used the 
> "pollirq" kernel option may be required in dom0.

just a note.

We have some recent remotes sampling from IRQs triggered by a gpio pin
without any additional IR chip.

There are some reports that "pollirq" makes them unusable, since
sensible timings are lost.

No such reports from xen stuff yet, but the same might happen with
shared IRQs and "pollirq" there too.

Cheers,
Hermann


> Signed-off-by: Andy Burns <andy at burns.net>
> ---- drivers/media/video/saa7134/saa7134-core.c.orig     2008-07-01 
> 16:46:49.000000000 +0100
> +++ drivers/media/video/saa7134/saa7134-core.c  2008-07-02 
> 16:41:37.000000000 +0100
> @@ -908,7 +908,8 @@
>                         dev->name,(unsigned long 
> long)pci_resource_start(pci_dev,0));
>                  goto fail1;
>          }
> -       dev->lmmio = ioremap(pci_resource_start(pci_dev,0), 0x1000);
> +       dev->lmmio = ioremap(pci_resource_start(pci_dev,0),
> +                             pci_resource_len(pci_dev,0));
>          dev->bmmio = (__u8 __iomem *)dev->lmmio;
>          if (NULL == dev->lmmio) {
>                  err = -EIO;
> 
> 





More information about the linux-dvb mailing list