[linux-dvb] DVBFE_SET_PARAMS / delsys from fe_info ioctl ?

[Manu Abraham]

Florian Lohoff wrote:
> On Mon, Mar 03, 2008 at 03:09:23PM +0400, Manu Abraham wrote:
>>> As i already wrote - SET_PARAMS is _NOT_ enough. Please try yourself. 
>>> Unload/Load the module and simple issue a DVBFE_SET_PARAMS (NOT
>>> GET_INFO) and it doesnt tune/lock at least for STB0899 and it also
>>> complains in the dmesg with:
>>>
>>> 	stb0899_search: Unsupported delivery system 0
>>> 	stb0899_read_status: Unsupported delivery system 0
>>> 	stb0899_search: Unsupported delivery system 0
>>> 	stb0899_read_status: Unsupported delivery system 0
>>> 	stb0899_search: Unsupported delivery system 0
>>> 	stb0899_read_status: Unsupported delivery system 0
>>>
>>> although i set
>>>
>>> 	dvbfe_params.delivery=DVBFE_DELSYS_DVBS2;
>> Yep, it isn't supposed to work that way with simply issuing SET_PARAMS.
> 
> Okay - So either 
> 
> - remove the "delivery" in the dvbfe_params because it is unnecessary,
>   confusing and broken, and rename the GET_INFO call to SET_DELIVERY
>   or something which implies that its not a _GET_ call

As you can see, removing delivery is not an option, since GET_PARAMS 
operates
on the same data structure. Removal of which will require the application to
issue an additional ioctl call.

> or 
> 
> - make SET_PARAMS the call to honor delivery in dvbfe_params and remove
>   the setting of the delivery of GET_INFO
> 
> I'd prefere the 2nd option because currently the usage and naming
> is an incoherent mess which should better not get more adopters ..

Your 2nd option won't work at all. It is completely broken when you have
to query statistics, before a SET_PARAMS.

Additionally, this was quite discussed in a long discussion a while 
back. You
might like to read through those as well.

Maybe DVBFE_GET_INFO can probably be renamed to DVBFE_INFO if it really
itches so much.

HTH,
Manu