[linux-dvb] [PATCH 3/5] USB suspend and hibernation support for Siano's SMS chip-set based devices.

Michael Krufky mkrufky at linuxtv.org
Sun Nov 23 06:08:10 CET 2008


2008/11/19 Uri Shkolnik <urishk at yahoo.com>:
> This patch provides USB suspend and hibernation support for Siano's SMS chipset based USB device
>
> Signed-off-by: Uri Shkolnik <uris at siano-ms.com> hibernation

Uri,

Thanks for posting these patches.

It looks like you diff'd the files in the Siano repository against the
files in the dvb tree.  In the future, please be careful not to tangle
unrelated changes into your patches.  When a patch changes only the
code that it needs to change, it makes it easier for the patches to be
reviewed and merged quicker.

For instance, the patch in your email introduces regressions that
cause compile warnings under 64bit operating systems.  This is caused
by changes in the patch that are not related at all to the
suspend/resume functionality.

I stripped away the unrelated portions of the patch, so the only
changes remaining were those that enable the suspend / resume
functionality, as described in your patch description.

The result changeset is pending merge into the master branch, and is
currently the topmost patch in my sms1xxx tree, here:

http://linuxtv.org/hg/~mkrufky/sms1xxx

I haven't yet had a chance to give a thorough review to the other
patches yet.  I'll try to follow-up soon.

Cheers,

Mike



More information about the linux-dvb mailing list