[linux-dvb] XC4000: added card_type

Devin Heitmueller dheitmueller at kernellabs.com
Fri Jun 3 14:46:46 CEST 2011


On Fri, Jun 3, 2011 at 8:38 AM, istvan_v at mailbox.hu <istvan_v at mailbox.hu> wrote:
> This patch adds support for selecting a card type in struct
> xc4000_config, to allow for implementing some card specific code
> in the driver.
>
> Signed-off-by: Istvan Varga <istvan_v at mailbox.hu>

Hi Istan,

I understand what you're trying to do here, but this is not a good
approach.  We do not want to be littering tuner drivers with
card-specific if() statements.  Also, this is inconsistent with the
way all other tuner drivers work.

The approach you are attempting may seem easier at first, but it gets
very difficult to manage over time as the number of boards that use
the driver increases.

You should have the bridge driver be setting up the cfg structure and
passing it to the xc4000 driver, just like the xc5000 and xc3028 do.

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com



More information about the linux-dvb mailing list