I beleive this change this change is correct because it's specified
this way in the specifications of the cx24123, the only other card that
uses the set_voltage is the Kworld dvb-s 100, The other cx24123 based card Huappage NovaSE uses the isl6421 for lnb control. I can show you the specifications is you need confirmation but I'm pretty sure this is the correct way to do this. 
<br><br><div><span class="gmail_quote">On 6/29/06, <b class="gmail_sendername">Andrew de Quincey</b> &lt;<a href="mailto:adq_dvb@lidskialf.net">adq_dvb@lidskialf.net</a>&gt; wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
On Thursday 29 June 2006 05:58, Michael Krufky wrote:<br>&gt; Saqeb,<br>&gt;<br>&gt; &gt;diff -r 8feabb5c0eae -r ce921c4dce88<br>&gt; &gt; linux/drivers/media/dvb/frontends/cx24123.c ---<br>&gt; &gt; a/linux/drivers/media/dvb/frontends/cx24123.c&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Tue Jun 27 03:57:46 2006
<br>&gt; &gt; +++ b/linux/drivers/media/dvb/frontends/cx24123.c&nbsp;&nbsp; Wed Jun 28 16:56:42<br>&gt; &gt; 2006 @@ -681,10 +681,10 @@<br>&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; switch (voltage) {<br>&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; case SEC_VOLTAGE_13:<br>&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; dprintk(&quot;%s: setting voltage 13V\n&quot;, __FUNCTION__);
<br>&gt; &gt;-&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;return cx24123_writereg(state, 0x29, val | 0x80);<br>&gt; &gt;+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;return cx24123_writereg(state, 0x29, val &amp; 0x7f);<br>&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; case SEC_VOLTAGE_18:<br>&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; dprintk(&quot;%s: setting voltage 18V\n&quot;, __FUNCTION__);
<br>&gt; &gt;-&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;return cx24123_writereg(state, 0x29, val &amp; 0x7f);<br>&gt; &gt;+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;return cx24123_writereg(state, 0x29, val | 0x80);<br>&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; default:<br>&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return -EINVAL;
<br>&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; };<br>&gt;<br>&gt; ^^^ How do you know this change is correct?&nbsp;&nbsp;(I don't doubt it -- I<br>&gt; wouldn't know)&nbsp;&nbsp;What problem does this change solve for you?&nbsp;&nbsp;I think<br>&gt; you should ask some other users of cards with a cx24123 to confirm that
<br>&gt; this doesnt break anything, and achieves the desired results.<br><br>Yeah I was wondering about that; the other DVBS cx24123 cards do seem to work<br>correctly with the original setting. Perhaps this new card is simply wired up
<br>differently. If thats the case you'll need to add a new config parameter<br>(e.g. 'voltage_wiring') to the cx24123_config structure in order to support<br>both wiring types.<br></blockquote></div><br><br clear="all"><br>
-- <br>Saqeb Akhter