<br><br><div class="gmail_quote">On Jan 27, 2008 7:58 AM, Timothy E. Krantz <<a href="mailto:tkrantz@stahurabrenner.com">tkrantz@stahurabrenner.com</a>> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><div></div><div class="Wj3C7c">> Hi, all,<br>><br>> This patch improves the performance of the xc5000 tuner driver.<br>><br>> 1. Now, only one xc5000_priv struct is used for each physical tuner<br>> instead of one for each attach (analog/digital). This<br>
> avoids potential<br>> inconsistence such as the status of the firmware loading changed by<br>> one instance of the driver and the other instance not<br>> being aware of it.<br>> It is based on the tuner-xc2028.c code.<br>
><br>> 2. Removed a layer of function call for xc_reset().<br>><br>> 3. Replaced all calls to xc_wait() by a direct msleep() call<br>> (which is all<br>> xc_wait does).<br>><br>> 4. Changed the xc_wait(100) in xc_write_reg() to msleep(5).<br>
> The comment<br>> says wait 5 ms, was the 100 a typo? In any case, this improved the<br>> tuner performace greatly (much faster lock).<br>><br>> 5. Added a module parameter "allow_shutdown", which is defaulted to 0.<br>
> If enabled, the xc5000_sleep() function will indeed shutdown the<br>> tuner device. On the 800i, this is fine with analog, but digital<br>> still cannot get a lock after shutdown and reinitialized, with no<br>
> apparent error message. Please test this on other cards.<br>><br>> 6. Some minor clean up.<br>><br>> The patch is tested on the Pinnacle 800i. Before the patch,<br>> tvtime and azap works with analog/digital tv, but with very<br>
> slow tuning and locking. Mythtv had problems with analog tv<br>> frequently (with the "errors are encountered during video<br>> play back" message). Most likely, that was due to the slow<br>> tuning of the xc5000.<br>
><br>> After the patch, both analog and digital tv saw great improvements.<br>> Mythtv can consistently lock in both analog and digital<br>> channels. I haven't run into the video play back errors yet<br>> so far after torturing mythtv with channel changing and<br>
> switching between different input source/multiple cards<br>> several dozen times.<br>><br>> I still could not get audio (analog) in mythtv, but I suspect<br>> that is a problem with my mythtv setup rather than the driver.<br>
><br>> Comments are welcome and please test and post your experience. Thanks!<br><br></div></div>Sir,<br>Prior to your patch when using my 800i each time I tried to go from an<br>analog to a digital station or vice versa using mythtv I got the "errors<br>
encountered during video playback" issue.<br><br>With this patch installed going from analog to digital works fine for me but<br>switching from digital to analog still results in the same error.<br><br>Channel lock is MUCH faster.<br>
<br>Thanks for your efforts!<br><br>Tim<br><div><div></div><div class="Wj3C7c"><br></div></div></blockquote><div> </div></div><br>I apologize for being a newbie, but how does one apply a patch like this? It seems like you are supposed to run a patch command, but I can't figure out how to get it to run correctly.<br>
<br>Thanks<br><br>John<br>