<div>
<div>
Steve,<br><br>I have reworked the tuner callback now against your branch at:<span id="obmessage"><br>http://linuxtv.org/hg/~stoth/v4l-dvb<br><br>The new Patch (to add support for this card) is attached inline below for testing (this is a hint Mark & Jon), I have not provided a signed-off note on purpose as I want to solve the issue mentioned in the next paragraph first.<br><br>Regarding the cx25840 module; the card doesn't seem to initialise properly (no DVB output and DMA errors in log) unless I have this requested. Once the card is up and running I can unload all drivers, recompile without the cx25840 and load and it will work again until I power off the computer and back on again (This has been tedious trying to work out which setting I had missed). Is there some initialisation work being performed in the cx25840 module that I can incorporate into my patch to remove this dependency? Or should I leave it as is?<br><br>Anyway nearly bedtime here.<br><br>Regards,<br>Stephen.<br></span>
<br><br>--------Patch------<br>diff -Naur v4l-dvb/linux/Documentation/video4linux/CARDLIST.cx23885 v4l-dvb2/linux/Documentation/video4linux/CARDLIST.cx23885<br>--- v4l-dvb/linux/Documentation/video4linux/CARDLIST.cx23885 2008-08-05 16:48:13.000000000 +1000<br>+++ v4l-dvb2/linux/Documentation/video4linux/CARDLIST.cx23885 2008-08-05 20:07:16.000000000 +1000<br>@@ -10,3 +10,4 @@<br> 9 -> Hauppauge WinTV-HVR1400 [0070:8010]<br> 10 -> DViCO FusionHDTV7 Dual Express [18ac:d618]<br> 11 -> DViCO FusionHDTV DVB-T Dual Express [18ac:db78]<br>+ 12 -> Leadtek Winfast PxDVR3200 H [107d:6681]<br>diff -Naur v4l-dvb/linux/drivers/media/video/cx23885/cx23885-cards.c v4l-dvb2/linux/drivers/media/video/cx23885/cx23885-cards.c<br>--- v4l-dvb/linux/drivers/media/video/cx23885/cx23885-cards.c 2008-08-05 16:48:14.000000000 +1000<br>+++ v4l-dvb2/linux/drivers/media/video/cx23885/cx23885-cards.c 2008-08-05 21:29:59.000000000 +1000<br>@@ -155,6 +155,10 @@<br> .portb = CX23885_MPEG_DVB,<br> .portc = CX23885_MPEG_DVB,<br> },<br>+ [CX23885_BOARD_LEADTEK_WINFAST_PXDVR3200_H] = {<br>+ .name = "Leadtek Winfast PxDVR3200 H",<br>+ .portc = CX23885_MPEG_DVB,<br>+ },<br> };<br> const unsigned int cx23885_bcount = ARRAY_SIZE(cx23885_boards);<br> <br>@@ -230,7 +234,11 @@<br> .subvendor = 0x18ac,<br> .subdevice = 0xdb78,<br> .card = CX23885_BOARD_DVICO_FUSIONHDTV_DVB_T_DUAL_EXP,<br>- },<br>+ },{<br>+ .subvendor = 0x107d,<br>+ .subdevice = 0x6681,<br>+ .card = CX23885_BOARD_LEADTEK_WINFAST_PXDVR3200_H,<br>+ },<br> };<br> const unsigned int cx23885_idcount = ARRAY_SIZE(cx23885_subids);<br> <br>@@ -353,6 +361,10 @@<br> if (command == 0)<br> bitmask = 0x04;<br> break;<br>+ case CX23885_BOARD_LEADTEK_WINFAST_PXDVR3200_H:<br>+ /* Tuner Reset Command */<br>+ bitmask = 0x00070404;<br>+ break;<br> case CX23885_BOARD_DVICO_FUSIONHDTV_7_DUAL_EXP:<br> case CX23885_BOARD_DVICO_FUSIONHDTV_DVB_T_DUAL_EXP:<br> if (command == 0) {<br>@@ -492,6 +504,15 @@<br> mdelay(20);<br> cx_set(GP0_IO, 0x000f000f);<br> break;<br>+ case CX23885_BOARD_LEADTEK_WINFAST_PXDVR3200_H:<br>+ /* GPIO-2 xc3028 tuner reset */<br>+ /* Put the parts into reset and back */<br>+ cx_set(GP0_IO, 0x00040000);<br>+ mdelay(20);<br>+ cx_clear(GP0_IO, 0x00000004);<br>+ mdelay(20);<br>+ cx_set(GP0_IO, 0x00040004);<br>+ break;<br> }<br> }<br> <br>@@ -579,6 +600,7 @@<br> case CX23885_BOARD_HAUPPAUGE_HVR1200:<br> case CX23885_BOARD_HAUPPAUGE_HVR1700:<br> case CX23885_BOARD_HAUPPAUGE_HVR1400:<br>+ case CX23885_BOARD_LEADTEK_WINFAST_PXDVR3200_H:<br> default:<br> ts2->gen_ctrl_val = 0xc; /* Serial bus + punctured clock */<br> ts2->ts_clk_en_val = 0x1; /* Enable TS_CLK */<br>@@ -592,6 +614,7 @@<br> case CX23885_BOARD_HAUPPAUGE_HVR1800:<br> case CX23885_BOARD_HAUPPAUGE_HVR1800lp:<br> case CX23885_BOARD_HAUPPAUGE_HVR1700:<br>+ case CX23885_BOARD_LEADTEK_WINFAST_PXDVR3200_H:<br> request_module("cx25840");<br> break;<br> }<br>diff -Naur v4l-dvb/linux/drivers/media/video/cx23885/cx23885-dvb.c v4l-dvb2/linux/drivers/media/video/cx23885/cx23885-dvb.c<br>--- v4l-dvb/linux/drivers/media/video/cx23885/cx23885-dvb.c 2008-08-05 16:48:14.000000000 +1000<br>+++ v4l-dvb2/linux/drivers/media/video/cx23885/cx23885-dvb.c 2008-08-05 21:29:00.000000000 +1000<br>@@ -37,6 +37,7 @@<br> #include "tda8290.h"<br> #include "tda18271.h"<br> #include "lgdt330x.h"<br>+#include "zl10353.h"<br> #include "xc5000.h"<br> #include "tda10048.h"<br> #include "tuner-xc2028.h"<br>@@ -502,6 +503,32 @@<br> }<br> break;<br> }<br>+ case CX23885_BOARD_LEADTEK_WINFAST_PXDVR3200_H:<br>+ i2c_bus = &dev->i2c_bus[0];<br>+ <br>+ port->dvb.frontend = dvb_attach(zl10353_attach,<br>+ &dvico_fusionhdtv_xc3028,<br>+ &i2c_bus->i2c_adap);<br>+ if (port->dvb.frontend != NULL) {<br>+ struct dvb_frontend *fe;<br>+ struct xc2028_config cfg = {<br>+ .i2c_adap = &dev->i2c_bus[1].i2c_adap,<br>+ .i2c_addr = 0x61,<br>+ .video_dev = port,<br>+ .callback = cx23885_tuner_callback,<br>+ };<br>+ static struct xc2028_ctrl ctl = {<br>+ .fname = "xc3028-v27.fw",<br>+ .max_len = 64,<br>+ .demod = XC3028_FE_ZARLINK456,<br>+ };<br>+ <br>+ fe = dvb_attach(xc2028_attach, port->dvb.frontend,<br>+ &cfg);<br>+ if (fe != NULL && fe->ops.tuner_ops.set_config != NULL)<br>+ fe->ops.tuner_ops.set_config(fe, &ctl);<br>+ }<br>+ break;<br> default:<br> printk("%s: The frontend of your DVB/ATSC card isn't supported yet\n",<br> dev->name);<br>diff -Naur v4l-dvb/linux/drivers/media/video/cx23885/cx23885.h v4l-dvb2/linux/drivers/media/video/cx23885/cx23885.h<br>--- v4l-dvb/linux/drivers/media/video/cx23885/cx23885.h 2008-08-05 16:48:14.000000000 +1000<br>+++ v4l-dvb2/linux/drivers/media/video/cx23885/cx23885.h 2008-08-05 20:10:57.000000000 +1000<br>@@ -66,6 +66,7 @@<br> #define CX23885_BOARD_HAUPPAUGE_HVR1400 9<br> #define CX23885_BOARD_DVICO_FUSIONHDTV_7_DUAL_EXP 10<br> #define CX23885_BOARD_DVICO_FUSIONHDTV_DVB_T_DUAL_EXP 11<br>+#define CX23885_BOARD_LEADTEK_WINFAST_PXDVR3200_H 12<br> <br> /* Currently unsupported by the driver: PAL/H, NTSC/Kr, SECAM B/G/H/LC */<br> #define CX23885_NORMS (\<br>diff -Naur v4l-dvb/linux/drivers/media/video/cx23885/Kconfig v4l-dvb2/linux/drivers/media/video/cx23885/Kconfig<br>--- v4l-dvb/linux/drivers/media/video/cx23885/Kconfig 2008-08-05 16:48:14.000000000 +1000<br>+++ v4l-dvb2/linux/drivers/media/video/cx23885/Kconfig 2008-08-05 20:06:06.000000000 +1000<br>@@ -15,6 +15,7 @@<br> select DVB_S5H1409 if !DVB_FE_CUSTOMISE<br> select DVB_S5H1411 if !DVB_FE_CUSTOMISE<br> select DVB_LGDT330X if !DVB_FE_CUSTOMISE<br>+ select DVB_ZL10353 if !DVB_FE_CUSTOMISE<br> select MEDIA_TUNER_XC2028 if !DVB_FE_CUSTOMIZE<br> select MEDIA_TUNER_TDA8290 if !DVB_FE_CUSTOMIZE<br> select MEDIA_TUNER_TDA18271 if !DVB_FE_CUSTOMIZE<br><br><br><br>-------End Patch-------<br>
<blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; padding-left: 5px;">----- Original Message -----<br>
From: "Steven Toth" <stoth@linuxtv.org><br>
To: stev391@email.com<br>
Subject: Re: [linux-dvb] [PATCH-TESTERS-REQUIRED] Leadtek Winfast PxDVR 3200 H - DVB Only support<br>
Date: Mon, 04 Aug 2008 10:35:20 -0400<br>
<br>
<br>
> case CX23885_BOARD_HAUPPAUGE_HVR1800:<br>
> case CX23885_BOARD_HAUPPAUGE_HVR1800lp:<br>
> case CX23885_BOARD_HAUPPAUGE_HVR1700:<br>
> + case CX23885_BOARD_LEADTEK_WINFAST_PXDVR3200_H:<br>
> request_module("cx25840");<br>
> break;<br>
> }<br>
<br>
Steve, thanks for look at this.<br>
<br>
I took a quick look at your patch. Obviously the callback stuff <br>
you're planning to re-work will be based Antons patch, which I plan <br>
to push tonight after more testing.... So I'm ignoring this.<br>
<br>
Minor nitpick... Don't request module cx25840 above unless you plan <br>
to use it. If you are planning to add analog support, make this a <br>
second patch after the digital stuff gets merged.<br>
<br>
Other than that, it will be great to have another product supported <br>
in the tree.<br>
<br>
Regards,<br>
<br>
- Steve<br>
</stoth@linuxtv.org></blockquote>
</div>
</div>
<BR>
--
<div> Be Yourself @ mail.com!<br>
Choose From 200+ Email Addresses<br>
Get a <b>Free</b> Account at <a href="http://www.mail.com/Product.aspx" target="_blank">www.mail.com</a>!</div>