<br><br><div class="gmail_quote">On Fri, Feb 27, 2009 at 6:35 AM, hermann pitton <span dir="ltr"><<a href="mailto:hermann-pitton@arcor.de">hermann-pitton@arcor.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi,<br>
<br>
Am Mittwoch, den 25.02.2009, 20:42 +0000 schrieb erik:<br>
<div><div></div><div class="h5">> klaas de waal <klaas.de.waal <at> <a href="http://gmail.com" target="_blank">gmail.com</a>> writes:<br>
> ><br>
> > On Fri, Oct 10, 2008 at 2:36 AM, hermann pitton <hermann-pitton <at> <a href="http://arcor.de" target="_blank">arcor.de</a>><br>
> wrote:<br>
> > Hi,<br>
> > Am Donnerstag, den 09.10.2008, 22:15 +0200 schrieb klaas de waal:<br>
> > The table starts a new segment at 390MHz,<br>
> > > it then starts to use VCO2 instead of VCO1.<br>
> > > I have now (hack, hack) changed the segment start from 390 to 395MHz<br>
> > > so that the 388MHz is still tuned with VCO1, and this works OK!!<br>
> > > Like this:<br>
> > ><br>
> > > static const struct tda827xa_data tda827xa_dvbt[] = {<br>
> > > { .lomax = 56875000, .svco = 3, .spd = 4, .scr = 0, .sbs =<br>
> > > 0, .gc3 = 1},<br>
> > > #else<br>
> > > { .lomax = 395000000, .svco = 2, .spd = 1, .scr = 0, .sbs =<br>
> > > 3, .gc3 = 1},<br>
> > > #endif<br>
> > > { .lomax = 455000000, .svco = 3, .spd = 1, .scr = 0, .sbs =<br>
> > > 3, .gc3 = 1},<br>
> > > etc etc<br>
> > ><br>
><br>
> Hi Klaas/Hermann<br>
><br>
> Your fix works perfectly for me as well. Prior I could not get the channels in<br>
> the 386750000 freq. With Fix appied my Ziggo locking issues disappeared.<br>
><br>
> Is there any chance to get it into the official version?<br>
><br>
> Erik<br>
><br>
<br>
</div></div>yes, there should be one for the later patch with the separate tuning<br>
table for tda8274a DVB-C I think.<br>
<br>
Patch for a review must be against recent mercurial v4l-dvb, needs to be<br>
in form of a unified diff, with mercurial installed and v4l-dvb cloned<br>
"hg diff > tda827x_dvb-c_improved-tuning-table.patch" something does<br>
create it most simple.<br>
<br>
Needs to go to <a href="mailto:linux-media@vger.kernel.org">linux-media@vger.kernel.org</a> , please try README.patches<br>
in the v4l-dvb Documentation. Needs a Signed-off-by line.<br>
<br>
Also testers like you should provide a Tested-by line to promote it.<br>
<br>
Don't know if somebody has the tuning table for that specific tuner,<br>
tda8274a IIRC, or if this will only rely on the reports of the testers.<br>
<br>
Some equivalent of lna config = 0 needs to be introduced too to keep it<br>
quiet was said as well.<br>
<br>
Cheers,<br>
<font color="#888888">Hermann<br>
<br>
<br>
<br>
</font></blockquote><div>Hi Hermann,<br><br>Thanks for your "howto" on making a proper patch.<br>After a "make commit" in my local v4l-dvb tree, and filling in the template I got the following output. I confess I do not know if this has now ended up somewhere in <a href="http://linuxtv.org">linuxtv.org</a> or that it is just local.<br>
However, here it is:<br><br>changeset: 11143:f10e05176a88<br>tag: tip<br>user: Klaas de Waal <<a href="mailto:klaas.de.waal@gmail.com">klaas.de.waal@gmail.com</a>><br>date: Tue Mar 24 22:59:44 2009 +0100<br>
files: linux/drivers/media/common/tuners/tda827x.c linux/drivers/media/dvb/ttpci/budget-ci.c<br>description:<br>Separate tuning table for DVB-C solves tuning problem at 388MHz.<br><br>From: Klaas de Waal <<a href="mailto:klaas.de.waal@gmail.com">klaas.de.waal@gmail.com</a>><br>
<br>TechnoTrend C-1501 DVB-C card does not lock on 388MHz.<br>I assume that existing frequency table is valid for DVB-T. This is suggested<br>by the name of the table: tda827xa_dvbt.<br>Added a table for DVB-C with the name tda827xa_dvbc.<br>
Added runtime selection of the DVB-C table when the tuner is type FE_QAM.<br>This should leave the behaviour of this driver with with DVB_T tuners unchanged.<br>This modification is in file tda827x.c<br><br>The tda827x.c gives the following warning message when debug=1 :<br>
tda827x: tda827x_config not defined, cannot set LNA gain!<br>Added a tda827x_config struct in budget-ci.c to get rid of this message.<br><br>Priority: normal<br><br>Signed-off-by: Klaas de Waal <<a href="mailto:klaas.de.waal@gmail.com">klaas.de.waal@gmail.com</a>><br>
<br><br>I have attached the result of "hg diff > tda827x_dvb-c_tuning_table.patch.<br>Patch is with the "hg clone" done 23 march.<br>Tested with Linux kernel 2.6.28.9.<br><br>Cheers,<br>Klaas.<br><br><br>
<br> </div></div><br>