[vdr] Centralized 'thread active' handling

Stefan Huelswitt s.huelswitt at gmx.de
Sat Aug 13 15:59:29 CEST 2005


On 13 Aug 2005 Klaus Schmidinger <Klaus.Schmidinger at cadsoft.de> wrote:

Hi,

> Fixed a race condition in cTransfer (thanks to Klaus ??? for reporting this one).
> In doing so, the 'active' variables used by the actual derived cThread classes
> have been replaced by the cThread::Active() function. The previous functionality
> of cThread::Active() has been moved into the new cThread::Running().
> Plugin authors should check their derived cThread classes and replace any 'active'
> variables the same way as, for instance, done in transfer.c.

Wouldn't it be better to leave Active() untouched (instead of
renaming to Running()) and create a new (differently named)
function for the active var replacement? (e.g. Continue(), which
would give good readability with while(Continue()))

This would limit the impact this change has to plugins.

Otherwise a plugins using Active() now, could compile fine with
the next VDR version, but certainly wouldn't work correctly.

Regards.

-- 
Stefan Huelswitt
s.huelswitt at gmx.de  | http://www.muempf.de/



More information about the vdr mailing list