[vdr] Concerns about changing the API-definition of 'cStatus::Replaying()' and 'cStatus::Recording()' of VDR?

Klaus Schmidinger Klaus.Schmidinger at cadsoft.de
Sun Dec 18 17:40:15 CET 2005


Andreas Brugger wrote:
> Sascha Volkenandt schrieb:
> 
>> On Friday 16 December 2005 01:27, Udo Richter wrote:
>>  
>>
>>> Well, on a very long term. This could even go that far to start playing
>>> an URI, and VDR checks which plugin can play it back. Different plugins
>>> could use one generic VDR playback sources dialog, instead of each
>>> having its own file selector.
>>>   
>>
>>
>> Yes, that was my (and some others') initial thought, too, but I'd not 
>> dare suggesting that before 1.5 :-D
>>  
>>
> Now it would be interesting to see what Klaus thinks about the proposed 
> changes for vdr-1.4 ... Klaus? ;-)

Well, switching from

   void Recording(const cDevice *Device, const char *Name)

to

   void Recording(const cDevice *Device, const cRecording* Recording)

would only allow actual VDR recordings to work with this, so that's
out of the question.

So it's either

   void Recording(const cDevice *Device, const char *FileName)

which would be code compatible but might break plugins at runtime that
rely on the string being a pure name, or

   void Recording(const cDevice *Device, const char *Name, const char *FileName)

which extends the interface to hold a second parameter that contains
the actual file name (or NULL, if there is none), but would break plugins
st compile time.

Same goes for Replaying(), of course.

To me it's all the same, so let's here the votes.

Klaus



More information about the vdr mailing list