[vdr] Re: [PATCH] "Natural" menu cursor 0.01

Klaus Schmidinger Klaus.Schmidinger at cadsoft.de
Sat Jun 18 12:27:58 CEST 2005


C.Y.M wrote:
> Patrick Gleichmann wrote:
> 
>>Hi,
>>thanks for this bug report.
>>
> 
> 
> I really like this patch and would like to know if there is a fix for vdr-1.3.26
> available?
> 
> @Klaus: Would you consider adding this functionality to core vdr (wrap around
> menus)?

Well, since I was at it, anyway, I finally have adopted this.

However, I didn't use the original code from Patrick "as is", because it

- would have looped endlessly if there was no selectable item
- made wrapping permanent - which at least I don't like
- moved cOsdMenu::CursorUp() after cOsdMenu::CursorDown() for no reason
- didn't adhere to the VDR coding style

Please try the attached code sequence, which is a drop in replacement
for the functions cOsdMenu::CursorUp/Down() and cOsdMenu::PageUp/Down().

For testing there is currently a

#define DO_WRAP 1

at the beginning of this code. Set it to 0 if you want to turn off wrapping.
There will be a setup option for this in the final version.

Please let me know whether this works as expected, so I can avoid
breaking this again ;-)

Klaus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vdr-1.3.26-cursor.new
Type: image/x-xbitmap
Size: 3383 bytes
Desc: not available
Url : http://www.linuxtv.org/pipermail/vdr/attachments/20050618/3035ea19/vdr-1.3.26-cursor.xbm


More information about the vdr mailing list