[vdr] Re: SourceCaps (was: vdr 1.3 SUSE RPMs)

Carsten Koch Carsten.Koch at icem.com
Sun Jun 19 13:49:21 CEST 2005


Klaus Schmidinger wrote:
...
> it would appear to me that this won't work if no SourceCaps are set.
> If you really want this to go into VDR then you need to make sure
> a system that does not have SourceCaps set (which IMHO will be the
> majority) will still work.

I fully agree that the default must be "source is provided".

I suppose a global flag "SourceCapsSet" which is initialized
to false and which is set true true by ParseSourceCaps should
do the trick?

After all, this is Christian's patch, so I do not want to take
it over unless Christian wants me to.
Christian, are you reading this?
Would you like to fix your patch so Klaus can accept it?


> 
> BTW: what's with this:
> 
> diff -ru /hetis/home/cko/VDR/sources.c VDR/sources.c
> --- /hetis/home/cko/VDR/sources.c    2004-12-26 12:58:52.000000000 +0100
> +++ VDR/sources.c    2005-04-05 22:12:55.421326944 +0200
> @@ -68,7 +68,7 @@
>       int pos = 0;
>       bool dot = false;
>       bool neg = false;
> -     while (*++s) {
> +     while (*++s && !isblank(*s)) {
>             switch (toupper(*s)) {
>               case '0' ... '9': pos *= 10;
>                                 pos += *s - '0';
> 
> Obviously this has nothing to do with SourceCaps - but what's it for then?

I do not know.
My guess is that Christian needed this in a previous version of
cSetup::ParseSourceCaps? After all, cSetup::ParseSourceCaps is
calling cSource::FromString.
I believe this hunk can safely be omitted.


Carsten.



More information about the vdr mailing list