[vdr] [bug vdr-1.3.33] "Error while accessing recording" after deleting

[Klaus Schmidinger]

Udo Richter wrote:
> Hi Klaus,
> 
> I've tracked down a nasty "Error while accessing recording!" / "Fehler 
> beim Ansprechen der Aufzeichnung!" OSD message, occurring sometimes when 
> deleting recordings in sub folders. This only occurs if the deleted file 
> was the first one that was added to that sub folder - and maybe some 
> other conditions.
> 
> Thats what imho happens:
> -The file gets removed from OSD menu, Recordings list and disk.
> -cMenuRecordings::ProcessKey(kNone) triggers a Set() update of the 
> current menu.
> -After that, ProcessKey(kNone) of the main recordings menu triggers a 
> second Set() for the main recordings menu.
> -The second Set() call tries to remember the currently selected menu 
> entry (the currently open sub-menu) by calling GetRecording() for it.
> -GetRecording tries to find the matching recording by comparing file names.
> -Folders use the file name of one of their recordings as dummy, and, by 
> bad luck, this one is the one that was just deleted.
> -GetRecordings fails and throws the error.
> 
> 
> Something similar should happen if the currently selected menu item gets 
> externally deleted, but thats less likely.

I've come across this, too.
The patch I have posted here a little while ago under

   Re: [vdr] [bug vdr-1.3.33] invalid LastReplayed() opens first folder

should fix this.

Klaus