[vdr] Different between '#define MAXOSDAREAS 16' and '#define MAXNUMWINDOWS 7'

Klaus Schmidinger Klaus.Schmidinger at cadsoft.de
Sat Oct 1 23:35:05 CEST 2005


Udo Richter wrote:
> Klaus Schmidinger wrote:
> 
>> That's what the CanHandleAreas() function is for.
>> cOsd::SetAreas() calls the CanHandleAreas() of the derived
>> cOsd class, and in there cDvbOsd checks wheter (NumAreas > 
>> MAXNUMWINDOWS).
> 
> 
> Yes, I did understand that. But the generic cOsd::CanHandleAreas() does 
> not check for NumAreas > MAXOSDAREAS. If some cMyOsd can handle 32 
> areas, and only checks for NumAreas > 32, VDR may crash.
> 
> Not a realistic scenario though. ;)

Ah, now I see what you meant.
Of course, you have a point there.
I'll include such a check.

Klaus



More information about the vdr mailing list