[vdr] LoadPlugins should fail or ignore errors

Udo Richter udo_richter at gmx.de
Thu Feb 23 19:25:40 CET 2006


Hi Klaus,

I've stumbled over an inconsistency of the plugin load mechanism. Under 
regular conditions, plugins are loaded this way:

   if (!PluginManager.LoadPlugins(true)) EXIT(2);

If loading a plugin fails, maybe because of dynamic linker error or 
ProcessArgs() returned false, no further plugins will be loaded, and VDR 
exits.

In case of --help or --version however:

   PluginManager.LoadPlugins();

Now, if loading a plugin fails, VDR loads all plugins up to the failing 
one (which itself is in some in-between state), stops loading any more 
plugins, and outputs version and help for all plugins up to the failing 
one, maybe including the failing one. Version and help for all plugins 
_after_ the failing one is silently skipped.

Shouldn't LoadPlugins be non-fatal for --help and --version? Eg. add an 
option to continue if dll->Load() fails?

Cheers,

Udo



More information about the vdr mailing list