[vdr] cUnbufferedFile and NFS mounted video dir

Artur Skawina art_k at o2.pl
Fri Jan 27 15:05:32 CET 2006


Klaus Schmidinger wrote:
> Artur Skawina wrote:
>> --- vdr-1.3.39.org/cutter.c    2005-10-31 12:26:44.000000000 +0000
>> +++ vdr-1.3.39/cutter.c    2006-01-15 18:31:51.000000000 +0000
>> ...
>> @@ -118,10 +121,11 @@ void cCuttingThread::Action(void)
>>                   break;
>>                if (FileSize > MEGABYTE(Setup.MaxVideoFileSize)) {
>>                   toFile = toFileName->NextFile();
>> -                 if (toFile < 0) {
>> +                 if (!toFile) {
>> ...
>> @@ -158,10 +162,11 @@ void cCuttingThread::Action(void)
>>                   cutIn = true;
>>                   if (Setup.SplitEditedFiles) {
>>                      toFile = toFileName->NextFile();
>> -                    if (toFile < 0) {
>> +                    if (!toFile) {
>> ...
> 
> Are there more than these two actual bugfixes hidden in your patch?
> It might be a good idea to post such fixes separately, because I
> would certainly adopt these right away ;-)

i think these were the only two obvious ones; noticed them while playing w/ 
cutting readahead sizes; didn't think they were serious enough, so just fixed 
them in place.

However i consider the whole patch a bugfix :) Now that the fsyncs are disabled 
it probably isn't that critical though.

Having some kind of pluggable storage backend would be even better, as it would 
eg make nfs unnecessary and allow cache control and O_DIRECT even when using 
remote storage.

artur



More information about the vdr mailing list