[vdr] cUnbufferedFile and NFS mounted video dir

Klaus Schmidinger Klaus.Schmidinger at cadsoft.de
Sat Jan 28 14:51:11 CET 2006


Artur Skawina wrote:
> Klaus Schmidinger wrote:
> 
>> Artur Skawina wrote:
>>
>>> --- vdr-1.3.39.org/cutter.c    2005-10-31 12:26:44.000000000 +0000
>>> +++ vdr-1.3.39/cutter.c    2006-01-15 18:31:51.000000000 +0000
>>> ...
>>> @@ -118,10 +121,11 @@ void cCuttingThread::Action(void)
>>>                   break;
>>>                if (FileSize > MEGABYTE(Setup.MaxVideoFileSize)) {
>>>                   toFile = toFileName->NextFile();
>>> -                 if (toFile < 0) {
>>> +                 if (!toFile) {
>>> ...
>>> @@ -158,10 +162,11 @@ void cCuttingThread::Action(void)
>>>                   cutIn = true;
>>>                   if (Setup.SplitEditedFiles) {
>>>                      toFile = toFileName->NextFile();
>>> -                    if (toFile < 0) {
>>> +                    if (!toFile) {
>>> ...
>>
>>
>> Are there more than these two actual bugfixes hidden in your patch?
>> It might be a good idea to post such fixes separately, because I
>> would certainly adopt these right away ;-)
> 
> 
> i think these were the only two obvious ones; noticed them while playing 
> w/ cutting readahead sizes; didn't think they were serious enough, so 
> just fixed them in place.
> 
> However i consider the whole patch a bugfix :) Now that the fsyncs are 
> disabled it probably isn't that critical though.

So does this mean that without the fdatasync() calls it works ok as
it is in plain vanilla VDR (without any patch)?

What is the exact meaning of the "WriteStrategy" option?
Does it simply turn the fadvise stuff on/off, or is there more
magic behind it? I would prefer a version that works without this
option, because this is nothing a normal user would easily know
how to set.

So, if you can provide a patch against the latest VDR version that
still uses "#ifdef USE_FADVISE" to completely turn the fadvise
stuff off, and does _not_ introduce another setup option, I might
consider including it for the final version 1.4.

Klaus



More information about the vdr mailing list