[vdr] vdr 1.5.16 - minor problem in font.c

Klaus Schmidinger Klaus.Schmidinger at cadsoft.de
Fri Feb 29 14:36:47 CET 2008


On 02/29/08 14:29, Klaus Schmidinger wrote:
> On 02/29/08 01:04, Tobi wrote:
>> Hello,
>>
>> DrawText() in font.c uses the method Glyph() which may return a null pointer,
>> but doesn't check the returned pointer.
>>
>> I came across this bug, when checking a bug report from Sven Mueller:
>>
>> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=467512
>>
>> When info.vdr contains an invalid character (like in the above example a 0xA0 -
>> a Latin-1 NO-BREAK SPACE),  Glyph() returns null, which then causes a segfault
>> when dereferencing the null-pointer.
>>
>> The easiest way to fix this, would probably be to ignore such invalid
>> characters, which is, what the attached two-line-patch will do. But maybe it's
>> better to replace such characters with a default character - maybe a space or a '?'.
> 
> I also think showing some replacement character is best.
> 
> Can you please verify if the attached patch does this correctly?
> 
> If this works, I'd like to include it in version 1.6.0.

Maybe the attached version is even better, because there are also other
places where Glyph() is called.

Klaus

-------------- next part --------------
A non-text attachment was scrubbed...
Name: vdr-1.5.16-font-glyph-check.diff
Type: text/x-patch
Size: 569 bytes
Desc: not available
Url : http://www.linuxtv.org/pipermail/vdr/attachments/20080229/6bf597f6/attachment.bin 


More information about the vdr mailing list