[vdr] Include Path in Makefile (VDR >=1.7.15)

[Paul Menzel]

Am Sonntag, den 12.12.2010, 16:46 +0100 schrieb Paul Menzel:
> Am Sonntag, den 12.12.2010, 16:29 +0100 schrieb Klaus Schmidinger:
> > On 20.11.2010 11:39, Joachim Wilke wrote:
> > > 2010/11/19 Hans-Peter Jansen <hpj at urpla.net>:
> > >>> The HISTORY file states:
> > >>> "Include paths are now added instead of overwriting INCLUDES in the
> > >>> Makefile"
> > >>>
> > >>> However, in the Makefile changes:
> > >>> -INCLUDES = -I/usr/include/freetype2
> > >>> +INCLUDES ?= -I/usr/include/freetype2
> > >>>
> > >>> Shouldn't that be += instead of ?=.
> > >>
> > >> No, the conditional variable assignment operator ?= allows one to
> > >> replace this variable via command line/environment.
> > > 
> > > Thats not what the HISTORY reads. Either the Makefile or the HISTORY
> > > should be changed.
> > 
> > This change was posted here on the list by Paul Menzel on 2010-04-05.
> 
> The link to the message in the archive is [1].
> 
> > I guess the phrase "Include paths are now added instead of overwriting..."
> > in the HISTORY was my fault.
> > 
> > @Paul: would it be ok with you to make this
> > 
> > INCLUDES += -I/usr/include/freetype2
> > 
> > instead of
> > 
> > INCLUDES ?= -I/usr/include/freetype2
> 
> Reading my commit message,
> 
>         In some environments, i. e. when cross building, include files
>         are not located in the standard path like
>         `/usr/includes/freetype2`. Make it possible to provide the
>         correct path without needing to patch `Makefile`.
> 
> I would say that it would not work when cross compiling. I am no expert
> though. I would recommend to change the entry in HISTORY and I will ask
> on openembedded-devel what they suggest.

My message already got an answer [2] which advises to use `pkg-config`.

        IMO you should use pkg-config or freetype-config instead, e.g.:

        INCLUDES ?= `pkg-config --cflags freetype2`

        or better, instead of using INCLUDES at all:

        FREETYPE_CFLAGS ?= `pkg-config --cflags freetype2`
        CFLAGS += $(FREETYPE_CFLAGS)

        This will work in most environments.


Thanks,

Paul


> [1] http://www.linuxtv.org/pipermail/vdr/2010-April/022831.html
[2] http://lists.linuxtogo.org/pipermail/openembedded-devel/2010-December/027801.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://www.linuxtv.org/pipermail/vdr/attachments/20101212/3e131a70/attachment-0001.pgp>