[vdr] [PATCH] Makefile: pass `LDFLAGS` to compiler

Paul Menzel paulepanter at users.sourceforge.net
Sun Dec 12 18:31:38 CET 2010


Dear Jörg,


Am Samstag, den 25.09.2010, 13:15 +0200 schrieb Joerg Bornkessel:

[…]

> we have an open bug [1] to all versions of VDR  on gentoo
> 
> we changed any weeks befor our default profiles to use LDFLAGS
> on compile prozesses.
> 
> <snipp news-info about this from 2010-08-01>
> 
>        -Wl,--as-needed has been added to the default profile's LDFLAGS.
> 
>        This option optimizes the linking process, only linking binaries to
>        libraries that are trully needed. This way, fewer libraries are loaded
>        at runtime and fewer packages need to be rebuilt after library updates.
> 
> </snap>
> 
> For more information on --as-needed, read [2].
> 
> Plz. let us check is it possible to add a fix generally to the
> Makefile to respect the LDFLAGS or should i fixed always localy on
> gentoo Disti.
> 
> fixed should it be in this part of Makefile
> 
> -# The main program:
> -
> -vdr: $(OBJS) $(SILIB)
> -    $(CXX) $(CXXFLAGS) -rdynamic $(OBJS) $(LIBS) $(LIBDIRS) $(SILIB) -o vdr
> 
> +# The main program:
> +
> +vdr: $(OBJS) $(SILIB)
> +    $(CXX) $(CXXFLAGS) -rdynamic $(LDFLAGS) $(OBJS) $(LIBS) $(LIBDIRS) $(SILIB) -o vdr
> 
>
> [1] http://bugs.gentoo.org/show_bug.cgi?id=333493
> [2] http://www.gentoo.org/proj/en/qa/asneeded.xml

Should `LDFLAGS` also be passed to the compiler when building the
plugins?

I made a patch from your message which does not include any changes to
the plugins.


Thanks,

Paul

8<-------------------------------------------------------------------->8
Date: Sun, 12 Dec 2010 18:19:42 +0100

Some distributions pass special flags to the linker [1][2]. Respect those by using `LDFLAGS`.

[1] http://cgit.openembedded.org/cgit.cgi/openembedded/tree/recipes/vdr/vdr-1.7.10/linkerflags.patch
[2] http://www.linuxtv.org/pipermail/vdr/2010-September/023623.html

Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index cca4d55..e12e2b2 100644
--- a/Makefile
+++ b/Makefile
@@ -95,7 +95,7 @@ $(DEPFILE): Makefile
 # The main program:
 
 vdr: $(OBJS) $(SILIB)
-	$(CXX) $(CXXFLAGS) -rdynamic $(OBJS) $(LIBS) $(LIBDIRS) $(SILIB) -o vdr
+	$(CXX) $(CXXFLAGS) -rdynamic $(LDFLAGS) $(OBJS) $(LIBS) $(LIBDIRS) $(SILIB) -o vdr
 
 # The libsi library:
 
-- 
1.7.2.3
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://www.linuxtv.org/pipermail/vdr/attachments/20101212/98bd7b0a/attachment.pgp>


More information about the vdr mailing list