[vdr] [PATCH] tools.h: include `stdarg.h` to fix `error: 'va_list' has not been declared` with uClibc

Paul Menzel paulepanter at users.sourceforge.net
Mon Dec 13 10:12:29 CET 2010


Am Montag, den 13.12.2010, 00:18 +0100 schrieb Klaus Schmidinger:
> On 12.12.2010 23:03, Paul Menzel wrote:
> > From a94d15b582df5d1464cec8bc7dd68be46e1bf937 Mon Sep 17 00:00:00 2001
> > From: Paul Menzel <paulepanter at users.sourceforge.net>
> > Date: Sun, 12 Dec 2010 19:21:25 +0100
> > Subject: [PATCH] tools.h: include `stdarg.h`
> > 
> > For some reason using uClibc `tools.h` needs to have `stdarg.h` included explicitly. Otherwise it fails with the following error. Using Libc or EGLIBC this error does not surface.
> 
> Since tools.h uses va_list you're apparently right.
> I wonder which one of the other header files tools.h
> includes pulls in that declaration (apparently unnecessarily).

Sorry I have no idea.

> > ...
> > This change was made by Henning Heinhold when packaging VDR 1.7.10 for OpenEmbedded [1].
> > 
> > [1] http://cgit.openembedded.org/cgit.cgi/openembedded/tree/recipes/vdr/files/cplusplus.patch
> 
> So I'll mention Henning in the CONTRIBUTORS file then, if that's ok with you.

That would be fine.

> > Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
> > CC: Henning Heinold <heinold at inf.fu-berlin.de>
> > ---
> >  tools.h |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/tools.h b/tools.h
> > index 95c35ff..1fbe005 100644
> > --- a/tools.h
> > +++ b/tools.h
> > @@ -17,6 +17,7 @@
> >  #include <iconv.h>
> >  #include <math.h>
> >  #include <poll.h>
> > +#include <stdarg.h>
> >  #include <stddef.h>
> >  #include <stdint.h>
> >  #include <stdio.h>
> 
> The '#include <stdarg.h>' can then also be removed from tools.c,
> and apparently it's included unnecessarily in osd.c and receiver.c.

Good catches.


Thank you for your fast response and analysis,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://www.linuxtv.org/pipermail/vdr/attachments/20101213/0032c5fd/attachment.pgp>


More information about the vdr mailing list