[vdr] [PATCH] Makefile: pass `LDFLAGS` to compiler

Paul Menzel paulepanter at users.sourceforge.net
Mon Dec 13 11:56:23 CET 2010


Am Montag, den 13.12.2010, 11:29 +0100 schrieb Paul Menzel:
> Am Montag, den 13.12.2010, 00:29 +0100 schrieb Joerg Bornkessel:
> 
> > > Am Samstag, den 25.09.2010, 13:15 +0200 schrieb Joerg Bornkessel:
> > 
> > > […]
> > 
> > 
> > >> [2] http://www.gentoo.org/proj/en/qa/asneeded.xml
> > 
> > > Should `LDFLAGS` also be passed to the compiler when building the
> > > plugins?
> > 
> > We have this fixed global on Gentoo for all plugins.
> > All plugin Makefile's are sed'ed/patched to use the LDFLAGS.
> 
> Sorry, I do not know Gentoo’s build system. I found the patch for VDR
> [1] and the ebuild file [2].
> 
> I was wondering why skincurses had no patch applied or change regarding
> `LDFLAGS` [3] and for example vdr-burn [4] has a separate patch. Then I
> found `vdr-plugin.eclass` [5] where the replacement is done using `sed`.
> 
> > > I made a patch from your message which does not include any changes to
> > > the plugins.
> >
> > I dont know, what distri you use,
> 
> I am using the OpenEmbedded framework [6].
> 
> > one way would be to fix this in the make.global ( used up from
> > vdr-1.7.(not shure yet)) and inherit this in the plugin Makefile.
> > 
> > Should be standard in the vdr-1.7.x adapted plugin Makefiles
> 
> That is what my patch is for. I will send an updated patch.

One question left. Why does not `LDFLAGS` need to be passed in the
implicit rules?

        ### Implicit rules:
        
        %.o: %.c
        	$(CXX) $(CXXFLAGS) $(LDFLAGS) -c $(DEFINES) $(INCLUDES) $<


Thanks,

Paul


> [1] http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/media-video/vdr/files/vdr-1.6.0-ldflags.patch?view=markup
> [2] http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/media-video/vdr/vdr-1.6.0_p2-r5.ebuild?view=markup
> [3] http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/media-plugins/vdr-skincurses/ChangeLog?view=markup
> [4] http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/media-plugins/vdr-burn/files/vdr-burn-0.2.0_beta1_ldflags.diff?revision=1.1&view=markup
> [5] http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/vdr-plugin.eclass?view=markup
> [6] http://www.openembedded.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://www.linuxtv.org/pipermail/vdr/attachments/20101213/a0e60753/attachment.pgp>


More information about the vdr mailing list