[vdr] [PATCH v3] Gather necessary options for build in Make.global and include it.

Klaus Schmidinger Klaus.Schmidinger at tvdr.de
Sat Feb 6 12:29:58 CET 2010


On 29.01.2010 15:19, Paul Menzel wrote:
> Without this patch, if some options in `Makefile` were set outside `Makefile` and no `Make.config` existed with the necessary options, builds could fail. [1][2][3]
> 
> Therefore include strictly necessary options in `Make.global` and include this in all the Makefiles before `Make.config`.
> 
> [1] http://www.linuxtv.org/pipermail/vdr/2009-July/020977.html
> [2] http://www.linuxtv.org/pipermail/vdr/2009-December/021807.html
> [3] http://www.linuxtv.org/pipermail/vdr/2010-January/022235.html
> 
> v2: Use `include` instead of `-include` to get a warning/error if it is not present. [4]
> v3: Change according to Frank’s comments [5].
>  • Delete options set in `Make.global` from other Makefiles.
>  • Leave adding `-fPIC` to `C[XX]FLAGS` in `Make.config.template` as the flags get reset including `Make.config`.
>  • Modify `newplugin`.
> 
> [4] http://www.gnu.org/software/make/manual/make.html#Include
> [5] http://www.linuxtv.org/pipermail/vdr/2010-January/022243.html
> 
> Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
> ...

Is it safe to assume that this is the final version everybody
has agreed upon?

Klaus



More information about the vdr mailing list