[vdr] [PATCH] vdr-1.7.31 & small improvement for last viewed recording

Klaus Schmidinger Klaus.Schmidinger at tvdr.de
Wed Oct 3 14:46:19 CEST 2012


On 03.10.2012 13:29, Udo Richter wrote:
> Am 03.10.2012 12:28, schrieb Klaus Schmidinger:
>> Not really. If the last viewed recording has been deleted, this new
>> functionality could still kick in
>
> The patch above just checks the string presence. It should also check whether the string is an existing recording then.

When a recording is deleted, cReplayControl::ClearLastReplayed() sets that string to NULL
in case it is the deleted recording.

>> Sounds way too complex for my taste.
>
> Not necessarily. One way: When hitting play, check whether LastReplay exists, is a recording, and check whether the replay index is far from the file end. If not, show recordings menu.
>
>
> Another way: When writing index->StoreResume() in dvbplayer, check for file end and set a flag remembering that. Maybe together with LastReplayed file. Then, when hitting play, check for that flag and show recordings menu instead.

Don't like it.

Klaus



More information about the vdr mailing list