[vdr] [PATCH] Make RGYB buttons customizable (attempt 2)

Klaus Schmidinger Klaus.Schmidinger at tvdr.de
Sun Sep 9 14:53:42 CEST 2012


On 09.09.2012 14:10, Gero wrote:
> On Sunday 09 September 2012 - 13:20:24, Klaus Schmidinger wrote:
>> ..., but I don't think it would be a good idea to modify the actual
>> functionality of these buttons
>> ...
>> and it would also affect tools that issue key presses via the SVDRP
>> command HITK.
>>
>> So before I adopt this patch, I want to make it very clear that this is
>> *not* going to be the first step towards a "babylonical" confusion... ;-)
>
> Isn't that a big overkill?
>
> The buttons already have the ability to get labeled and plugin-developers can
> assign individual actions ...
>
> I think, nobody will start to redefine a red button to become magenta or pink.
> ... and if a remote control exists, that have all color keys being black - I
> guess nobody would redefine the color buttons to become black1, black2, ...
> So I don't see the necessity to really change core code.
>
> The only agreed requirement is to be able to change the (visual) order of the
> buttons. The red button will stay red and a green button will continue being
> green. So there's no need to change SetHelp() call or the like. The order of
> the parameters of SetHelp() has very little in common with the visual
> representation - the parameter names of SetHelp() reflect the real button.
>
> Only the visual order needs to be customizable. If that's already a skin
> issue, I guess very little has to be changed in core vdr.

I'm not sure whether you understood what I meant.
Of course "red" will remain "red" etc. But a red button that has,
say, "Open" as its function will still have that function, even if it
is no longer the leftmost button.

Anyway, I have attached a revised version of the patch.
I have changed some variable names to better reflect the distinction
between "keys" on the remote control and "buttons" displayed on the
menus. I have also adjusted drawing the small rectangles to the left
of each color button in the LCARS skin.

Please have a look an let me know if there's anything wrong with this.

Klaus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vdr-1.7.29-customizecolorkeys.diff
Type: text/x-patch
Size: 13068 bytes
Desc: not available
URL: <http://www.linuxtv.org/pipermail/vdr/attachments/20120909/615c34ce/attachment.bin>


More information about the vdr mailing list