[vdr] [PATCH] MaxThemeName and MaxSkinName limit

Lucian Muresan lucianm at users.sourceforge.net
Sat Mar 23 17:14:44 CET 2013


Hi,

thank you Klaus for holding up your release plan for 2.0!
However, I hope this minor patch won't be too much trouble for you, as
it only increases the limit of 16 to theme and skin names, letting them
be NAME_MAX as almost any files, since these names can also be involved
in file names.
Was there a good reason to limit them at 16 only, perhaps the fear that
the name won't fit on the OSD? I don't really think someone would really
make use of as many as 255 characters for this. On the other hand, users
just encountered crashes with plugins which (unfortunately, yet) have
themes of their own, when just adding a new theme with a name longer
than 16 and at the same time the original plugin author relied on
MaxThemeName when allocating the string length.
So, what do you think, easy to adopt?

Regards,
Lucian
-------------- next part --------------
diff -Naur vdr-1.7.42_orig/config.h vdr-1.7.42/config.h
--- vdr-1.7.42_orig/config.h	2013-03-16 16:12:14.000000000 +0100
+++ vdr-1.7.42/config.h	2013-03-23 16:57:48.378701000 +0100
@@ -53,8 +53,8 @@
 #define MAXOSDHEIGHT 1200
 
 #define MaxFileName NAME_MAX // obsolete - use NAME_MAX directly instead!
-#define MaxSkinName 16
-#define MaxThemeName 16
+#define MaxSkinName NAME_MAX // obsolete - use NAME_MAX directly instead!
+#define MaxThemeName NAME_MAX // obsolete - use NAME_MAX directly instead!
 
 // Basically VDR works according to the DVB standard, but there are countries/providers
 // that use other standards, which in some details deviate from the DVB standard.


More information about the vdr mailing list