Development: How to submit patches: Difference between revisions

From LinuxTVWiki
Jump to navigation Jump to search
(change mailing list info!)
m (minor changes)
Line 7: Line 7:
Post your patches to the [mailto:majordomo@vger.kernel.org?body=subscribe%20linux-media linux-media] Mailing List for review and testing.
Post your patches to the [mailto:majordomo@vger.kernel.org?body=subscribe%20linux-media linux-media] Mailing List for review and testing.


Follow the guidelines in [http://lxr.linux.no/source/Documentation/SubmittingPatches Documentation/SubmittingPatches] (cf. [http://linux.yyz.us/patch-format.html jgarzik's version]), including:
Follow the guidelines in [[Development: Submitting Patches|Submitting Patches]] (cf. [http://linux.yyz.us/patch-format.html jgarzik's version]), including:
:* Verify best-practice [[Documentation/CodingStyle |kernel coding style]]
:* Verify best-practice [[Development: Coding Style|kernel coding style]]
:* Use [PATCH] in the subject line to get attention
:* Use [PATCH] in the subject line to get attention
:* Explain what the patch does and what hardware it applies to
:* Explain what the patch does and what hardware it applies to
:* Document your work where appropriate, in the form of patches to Documentation/video4linux files
:* Document your work where appropriate, in the form of patches to the Documentation/video4linux or Documentation/dvb files (which ever is appropriate)
:* Add a '''Signed-off-by: Your name <name@yoursite.com>''' as a [[Development: Submitting Patches#Developer.27s_Certificate_of_Origin_1.1|Developer's Certificate of Origin 1.1 ]]
:* Add a '''Signed-off-by: Your name <name@yoursite.com>''' as a [[Development: Submitting Patches#Developer.27s_Certificate_of_Origin_1.1|Developer's Certificate of Origin 1.1 ]]
:* Fix any problems and repeat until everyone is happy ;)
:* Fix any problems and repeat until everyone is happy ;)

Revision as of 00:48, 15 January 2009

Patch Preparation

Patches should be created against the V4L-DVB mercurial tree; see How to build from Mercurial.

For references on how to develop a driver, take a look at Index of Documentation for People Interested in Writing and/or Understanding the Linux Kernel.

Post your patches to the linux-media Mailing List for review and testing.

Follow the guidelines in Submitting Patches (cf. jgarzik's version), including:

  • Verify best-practice kernel coding style
  • Use [PATCH] in the subject line to get attention
  • Explain what the patch does and what hardware it applies to
  • Document your work where appropriate, in the form of patches to the Documentation/video4linux or Documentation/dvb files (which ever is appropriate)
  • Add a Signed-off-by: Your name <name@yoursite.com> as a Developer's Certificate of Origin 1.1
  • Fix any problems and repeat until everyone is happy ;)
  • Send the patch inline, not as an attachment

Hint: There's a checklist for patch submission

Subscription to the linux-media mailing list is recommended but not required.

The patch will be applied to the main mercurial tree. Once tested and integrated, patches are merged into a git tree by the V4L-DVB maintainer and periodically pulled by Linus.