Development: How to submit patches: Difference between revisions

From LinuxTVWiki
Jump to navigation Jump to search
(Updated to match the new development model)
m (Incorporated points from the old Patches page, which is now orphaned)
Line 13: Line 13:


I intend to send a first series of synchronizing patches to -mm this weekend. There is already a working first patch at the site.
I intend to send a first series of synchronizing patches to -mm this weekend. There is already a working first patch at the site.

Mauro

Mauro Carvalho Chehab <mchehab at brturbo dot com dot br>


=== The new development model ===
=== The new development model ===
Line 18: Line 22:
The new development model is now in place. While there is still no official maintainer of the video4linux subsystem of the linux kernel, a reliable procedure is in place for doing quality assurance, collecting patches, and submitting them to the linux kernel.
The new development model is now in place. While there is still no official maintainer of the video4linux subsystem of the linux kernel, a reliable procedure is in place for doing quality assurance, collecting patches, and submitting them to the linux kernel.


* The cvs tree at cvs.linuxtv.org is now the "master copy" of the video4linux subsystem
* The cvs tree at [http://cvs.linuxtv.org/cvs.php cvs.linuxtv.org] is now the master copy of the video4linux subsystem


* Patches should be built against video4linux cvs
* Patches should be built against video4linux cvs
Line 25: Line 29:


# Post your patches to the [https://www.redhat.com/mailman/listinfo/video4linux-list video4linux mailing list] for review and testing by other people
# Post your patches to the [https://www.redhat.com/mailman/listinfo/video4linux-list video4linux mailing list] for review and testing by other people
# Using [PATCH] in the subject line will help CVS maintainers spot it and provide feedback
## Using [PATCH] in the subject line will help CVS maintainers spot it and provide feedback
# Please edit the main ChangeLog to explain what you did and reflect your contribution (see Documentation/SubmittingPatches for details)
## Edit the main ChangeLog to explain what you did and reflect your contribution (see Documentation/SubmittingPatches for details)
## Provide some documentation of your work when appropriate -- users and future developers will thank you
# Reviewers should add a '''Signed-off-by: Your name <name@yoursite.com>''' when they approve a patch
## Minimally explain what the patch is for and what hardware you're testing it on
# Fix any problems and repeat until everyone is happy ;)
# Fix any problems and repeat until everyone is happy ;)
# Reviewers should add a '''Signed-off-by: Your name <name@yoursite.com>''' to indicate completed review
# Maintainers will periodically submit changes to mainstream, mailing it to the following
# Maintainers will periodically submit changes to mainstream, mailing it to the following:
## Linux kernel mailing list <linux-kernel@vger.kernel.org>
## Linux kernel mailing list <linux-kernel@vger.kernel.org>
## Andrew Morton <akpm@osdl.org> (the maintainer of the -mm tree)
## Andrew Morton <akpm@osdl.org> (the maintainer of the -mm tree)
## Gerd Knorr <kraxel@bytesex.org>
## Gerd Knorr <kraxel@bytesex.org>
## [https://www.redhat.com/mailman/listinfo/video4linux-list V4l mailing list]
## [https://www.redhat.com/mailman/listinfo/video4linux-list V4l mailing list]

Mauro

Mauro Carvalho Chehab <mchehab at brturbo dot com dot br>

Revision as of 18:54, 11 June 2005

Transition in maintainership

On the 8th of March 2005, Gerd Knorr announced that he was stepping down as the maintainer of the video4linux subsystem of the linux kernel. Gerd was responsible for coding a major part of the low-level drivers, his site at http://bytesex.org had been the hub of v4l development, and he had long served as the main quality assurance and relay for patches on the way to the kernel. In the mad scramble to come up with a workable development model, Johannes Stezenbach arranged for the development tree to be hosted at the LinuxTV.org site, and several developers stepped up to maintain the new CVS archive there. By 10 June 2005, Mauro Carvalho Chehab made the following announcement:

Video4linux snapshots available from linuxtv.org

We are now publishing periodic snapshots (about once a month) at linuxtv.org. The main idea is to have "stable" snapshots on Linuxtv. You can check it at:

http://www.linuxtv.org/downloads/video4linux/

The ChangeLog is also maintained at linuxtv.org. Our intention is to have one snapshot generated at the same time it is being submited to -mm series.

I intend to send a first series of synchronizing patches to -mm this weekend. There is already a working first patch at the site.

Mauro

Mauro Carvalho Chehab <mchehab at brturbo dot com dot br>

The new development model

The new development model is now in place. While there is still no official maintainer of the video4linux subsystem of the linux kernel, a reliable procedure is in place for doing quality assurance, collecting patches, and submitting them to the linux kernel.

  • The cvs tree at cvs.linuxtv.org is now the master copy of the video4linux subsystem
  • Patches should be built against video4linux cvs

How to get your changes into the mainline tree

  1. Post your patches to the video4linux mailing list for review and testing by other people
    1. Using [PATCH] in the subject line will help CVS maintainers spot it and provide feedback
    2. Edit the main ChangeLog to explain what you did and reflect your contribution (see Documentation/SubmittingPatches for details)
    3. Provide some documentation of your work when appropriate -- users and future developers will thank you
    4. Minimally explain what the patch is for and what hardware you're testing it on
  2. Fix any problems and repeat until everyone is happy ;)
  3. Reviewers should add a Signed-off-by: Your name <name@yoursite.com> to indicate completed review
  4. Maintainers will periodically submit changes to mainstream, mailing it to the following:
    1. Linux kernel mailing list <linux-kernel@vger.kernel.org>
    2. Andrew Morton <akpm@osdl.org> (the maintainer of the -mm tree)
    3. Gerd Knorr <kraxel@bytesex.org>
    4. V4l mailing list