Difference between revisions of "Development: How to submit patches"

From LinuxTVWiki
Jump to: navigation, search
m
m (Reverted edits by Ro0Nmx (Talk); changed back to last version by Js)
Line 3: Line 3:
 
Patches should be created against the v4l-dvb mercurial tree; see [[How to build from mercurial]].
 
Patches should be created against the v4l-dvb mercurial tree; see [[How to build from mercurial]].
  
For references on how to develop a driver, take a look at [http://jungla.dit.upm.es/~jmseyas/linux/kernel/hackers-docs.html Index of Documentation for People Interested in Writing and/or Understanding the Linux Kernel].
+
For references on how to develop a driver, take a look at [http://jungla.dit.upm.es/%7Ejmseyas/linux/kernel/hackers-docs.html Index of Documentation for People Interested in Writing and/or Understanding the Linux Kernel].
  
 
Post your patches to the [https://www.redhat.com/mailman/listinfo/video4linux-list video4linux mailing list] for review and testing.  
 
Post your patches to the [https://www.redhat.com/mailman/listinfo/video4linux-list video4linux mailing list] for review and testing.  

Revision as of 10:31, 24 June 2007

Patch Preparation

Patches should be created against the v4l-dvb mercurial tree; see How to build from mercurial.

For references on how to develop a driver, take a look at Index of Documentation for People Interested in Writing and/or Understanding the Linux Kernel.

Post your patches to the video4linux mailing list for review and testing.

Follow the guidelines in Documentation/SubmittingPatches (cf. jgarzik's version), including:

  • Verify best-practice kernel coding style
  • Use [PATCH] in the subject line to get attention
  • Explain what the patch does and what hardware it applies to
  • Document your work where appropriate, in the form of patches to Documentation/video4linux files
  • Add a Signed-off-by: Your name <name@yoursite.com> as a Developer's Certificate of Origin 1.1
  • Fix any problems and repeat until everyone is happy ;)
  • Send the patch inline, not as an attachment

Hint: There's a checklist for patch submission

Subscription to the V4l mailing list is recommended but not required.

The patch will be applied to the main mercurial tree. Once tested and integrated, patches are merged into a git tree by the v4l maintainer and periodically pulled by Linus.