[linux-dvb] Re: Small bugs in Video Disk Recorder version 0.90

[Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de>]

Matthias Weingart wrote:
> 
> On Tue, Aug 07, 2001 at 05:27:14PM +0200, Carsten Koch wrote:
> > Klaus Schmidinger wrote:
> > >
> > > Matthias Weingart wrote:
> > > >
> > > > Found some small bugs in vdr 0.9:
> > > > - change OSD size (X) to 51, the yellow key "eject dvd" is not shown correctly
> > > >   in the main menu
> > >
> > > I can't see a problem here (except that the text is a little out of center).
> >
> > I noticed that the colored buttons disappear altogether
> > when you increase the OSD size beyond a certain value.
> > I believe this is because the driver/firmware has limited
> > memory for the OSD and silently starts to not display
> > OSD windows when memory gets too tight. If I remember
> > correctly, there is currently no error code returned,
> > so vdr cannot catch this condition?
> >
> > Maybe this is what Matthias is sseing?
> 
> No, I reduced it from 52 to 51, and the text disappaers (the yellow colored
> range is still visible). I will try it again...

I didn't see it because it only happens with the German OSD texts.
Apply this patch to fix it:

--- interface.c 2001/07/28 14:57:52     1.39
+++ interface.c 2001/08/07 16:23:28
@@ -328,7 +328,7 @@
 {
   if (open && Text) {
      const int w = Width() / 4;
-     int l = (w - strlen(Text)) / 2;
+     int l = (w - int(strlen(Text))) / 2;
      if (l < 0)
         l = 0;
      cDvbApi::PrimaryDvbApi->Fill(Index * w, -1, w, 1, BgColor);

Can anybody come up with a shorter text than "DVD auswerfen"?
The English "Eject DVD" doesn't cause this problem.

Klaus
-- 
_______________________________________________________________

Klaus Schmidinger                       Phone: +49-8635-6989-10
CadSoft Computer GmbH                   Fax:   +49-8635-6989-40
Hofmark 2                               Email:   kls@cadsoft.de
D-84568 Pleiskirchen, Germany           URL:     www.cadsoft.de
_______________________________________________________________


-- 
Info:
To unsubscribe send a mail to listar@linuxtv.org with "unsubscribe linux-dvb" as subject.