[linux-dvb] Re: [RFC][ANNOUNCE] blindscan: auto search everything

[Andreas Oberritter <obi@linuxtv.org>]

Hi Roberto,

Am So, den 01.08.2004 schrieb Roberto Ragusa um 17:59:
+static int mt312_read_frequency_offset(struct dvb_i2c_bus *i2c, u16 *
frequency_offset)
+{
+       int ret;
+       u8 buf[2];
+
+       if ((ret = mt312_read(i2c, LNB_FREQ_H, &buf, sizeof(buf))) < 0)
+               return ret;

this should probably be buf, not &buf, although the address of the
pointer and the value of the pointer are the same for local arrays IIRC.

+       else{ //Auto symbol rate
+               if ((ret = set_tv_freq(i2c, p->frequency, 20000000)) <
0) //20000000 as placeholder
+                       return ret;
+

I don't understand how you specify the symbol rate range, but could you
replace the 20000000 by the average value of the range?

I am glad that you corrected mt312_get_symbol_rate(). Can you please 
split the patch so I can commit this part first?

Then, because we surely want to submit all changes to the official
kernel tree, it would be good to follow the kernel coding style, i.e.
replace c++ comments by c comments etc. Please have a look at 
linux/Documentation/CodingStyle.

Regards,
Andreas