Mailing List archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[linux-dvb] Re: pwm parameter for ves1820



Michael Hunold wrote:

Hi,

On 23.09.2004 00:42, Robert Schlabbach wrote:

From: "Lars Altenhain" <lars@altenhain.de>

Just putting the line "options ves1820 pwm=0x53,0x61" in
/etc/modules.conf worked perfectly for me, so I don't
understand why the parameter was removed.


I found this comment in the CVS:

- add back per-device pwm setting support, now done via sysfs attributes

1. Locate the pwm setting

find /sys/|grep "pwm"

/sys/devices/platform/i2c-0/0-0061/pwm
2. Set your desired value
echo "0x5c" > /sys/devices/platform/i2c-0/0-0061/pwm
3. Read the current value
more /sys/devices/platform/i2c-0/0-0061/pwm

Thanks for the investigations, Robert. 8-)

I removed the module parameter because providing a per-card parameter when loading the module is very unintentional. Additionally, the number of cards with a ves1820 was restricted by the size of array that held the per-card informations.

Using sysfs makes it a real per-card parameter.

Fixing the PWM byte EEPROM is trivial and would remove several lines of (usually dead) code. I would recommend this solution.

Holger





Home | Main Index | Thread Index