[linux-dvb] Re: refactoring

[Holger Waechtler <holger@qanu.de>]

Kenneth Aafløy wrote:

> On Friday 01 October 2004 15:40, Andrew de Quincey wrote:
>  
> > On Friday 01 Oct 2004 14:38, Andrew de Quincey wrote:
> >    
> > > On Friday 01 Oct 2004 14:26, Kenneth Aafløy wrote:
> > >      
> > > > Please, don't use select, that will force a user with a Nexus-S with the
> > > > stv0299 frontend to have all other frontends compiled in. This will
> > > > create bloated drivers, and actually would hurt the embedded platform
> > > > (Holger argued that the i2c core was huge, don't think he wants to be
> > > > forced to include more frontends)
> > > >
> > > > Use the default construct instead, which makes it possible to deselect,
> > > > but 'reminds' the user that it's probably a good idea to select this
> > > > item.
> > > >
> > > >        default y if VIDEO_CX88_DVB=y
> > > > default m if VIDEO_CX88_DVB=m
> > > >        
> > > That isn't going to work - card drivers are linked directly to frontend
> > > drivers by the exported XXX_attach() calls, and by the card's
> > > implementation of the PLL code.
> > >
> > > I'd suggest (for cards which need multiple frontends) we allow the users to
> > > customise which frontends have support compiled in for each card. By
> > > default, all of the frontends which the card might possibly need are
> > > selected.
> > >
> > > Therefore people who just want to get their new card going, and don't
> > > really care about the size of the resulting modules can quickly select the
> > > driver and not care about frontends (which realistically is going to be
> > > most end-users).
> > >
> > > However, people who do care about size will still have the option to
> > > customise exactly which frontend is supported.
> > >
> > > Sound ok?
> > >      
> > Actually - is that what you meant all along? i.e. using #ifdef DVBFE_BLAHBLAH 
> > in the card drivers.
> >    
> Yeah, was pondering on whether you was arguing with me or against me :)
> The #ifdef bloat won't be that much of a problem will it? The code in question
> will just be a function with a #ifdef block for each frontend?
> If there is only one frontend supported by an adapter, I can see no harm in
> 'select'ing it though.
>  
Please check the card list in the linuxtv wiki, most card types really 
come only with 1...3 demods used on this card.

Holger