Mailing List archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[vdr] Re: AC3 over DVB-s is possible - Part2



On 20 Feb 2002 Wolfgang Fiesel <fie@iis.fhg.de> wrote:

> 1../VDR/dvbapi.c -> dvbapi.diff
> 2. /VDR/Makefile -> Makefile1.diff
> 3. /VDR/ac3dec/decode.c -> decode.diff
> 4./VDR/ac3dec/Makefile -> Makefile2.diff
> 
> (call "patch -p1 original diff-file")

One thing: why don't you simply creates a single patch file with?

diff -urN old-vdr-dir/ new-vdr-dir/ >diff-file

You should do a "make clean" before this, to delete the
temporary files.

This is much easier to apply.


> -                   if (!Except || c != Except) {
> -                      int n = l;
> -                      for (int j = i; j < Length && n--; j++)
> -                          b[j] = 0x00;
> -                      }
> -                   break;
> +                   if (!Except || (c != Except && !LPCMsubID)){
> +      //printf("\nClear Audio: %x, LPCMsubID: %d",c,LPCMsubID);
> +      int n = l;
> +      for (int j = i; j < Length && n--; j++)
> +       b[j] = 0x00;
> +     }
> +     break;

I think, that it would make your patches more compatible with
other patches, if you wouldn't change spaces to tabs on lines
which aren't changed in any other way (like the int n=l line).

(generally I hate tabs, but this may be a personal problem).

-- 
Stefan Huelswitt
huels@iname.com  | http://home.pages.de/~nathan



Home | Main Index | Thread Index