Mailing List archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[vdr] Re: small fix for vdr-1.0.0pre1



Thilo Wunderlich wrote:
> 
> > but i belive that eit.c has a subtle problem, that cause a seg fault
> > when epg.dat does not exists.
> 
> Thats true, I just had the same problem. strace showed the seg fault
> when trying to read epg.dat (my main directory is not /video but
> /video/vdr and I didn't start vdr with the path)
> 
> Thilo

This is really a bug, but I believe the suggested fix from Andreas...

--- 1.2/eit.c   Sat Feb 23 19:11:19 2002
+++ edited/eit.c        Sun Feb 24 23:58:09 2002
@@ -1022,7 +1022,8 @@
             return false;
             }
          }
-     }
+     } else
+       return false;
    bool result = cSchedules::Read(f);
    if (OwnFile)
       fclose(f);

...should be modified because that way it always returns 'false' if
the incoming 'f' is NULL. It should only do so if the incoming 'f' is
NULL *and* the epg.data file does not exist. So the 'else...' should
be moved a little upwards.

I'll further look into this tonight.

Klaus
-- 
_______________________________________________________________

Klaus Schmidinger                       Phone: +49-8635-6989-10
CadSoft Computer GmbH                   Fax:   +49-8635-6989-40
Hofmark 2                               Email:   kls@cadsoft.de
D-84568 Pleiskirchen, Germany           URL:     www.cadsoft.de
_______________________________________________________________



Home | Main Index | Thread Index