[vdr] Re: VDR-bug (?): corrupt messages with replay mode diplay

[Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de>]

Ansgar Jonietz wrote:
> 
> Hi,
> 
> Sergei Haller schrieb:
> > AJ> when I'm looking a recording and the replay is in pause-mode the
> > AJ> pause-symbol "||" is displayed. If now a message like "low disk space"
> > AJ> appears I only see a short yellow bar at the bottom of the page; neither
> > AJ> the text nor the pause-symbol.
> >
> > after that neither menu nor other messages work. right?
> 
> No, menu works still after that.
> As far as I remember the progress display is displayed correct if I
> press "OK". (I can't reproduce it at the moment; I'm glad not to see
> this message...)
> 
> > this seems like a bug in one of the 0.9x versions (0.94?)
> 
> I think it's only a bug in VDR when displaying a message while the
> replay mode display is visible.
> 
> > Do you have the newest version of VDR?
> 
> Yes, if I remember correct the same problem occured with an older 0.99
> release.
> 
> It's not a big problem, but I think we should try to minimize the bugs
> in version 1.0...

The following changes should fix this. However, after a message is shown while
the replay mode "||" is displayed, the OSD line will appear grayed over the
entire screen width. But I guess this is still better than a useless message.
In version 1.1.x the replay mode will probably be displayed in a different
way, and then this will no longer happen.

Note that the line numbers may be off since I have made several other changes
to menu.c since version 1.0.0pre3.

Note to the AIO patchers: no need to issue another AIO patch right away - there
will most likely be VDR version 1.0.0pre4 tomorrow ;-)

--- menu.c      2002/03/16 10:06:18
+++ menu.c      2002/03/16 11:29:27
@@ -2991,6 +2991,8 @@
   if (s) {
      int w = dvbApi->WidthInCells(s);
      int d = max(Width() - w, 0) / 2;
+     if (modeOnly)
+        Interface->Fill(0, -1, Interface->Width(), 1, clrTransparent);
      Interface->Write(d, -1, s);
      Interface->Flush();
      }
@@ -3010,8 +3012,7 @@
            if (NormalPlay)
               return; // no need to do indicate ">" unless there was a different mode displayed before
            // open small display
-           Interface->Open(9, -1);
-           Interface->Clear();
+           Interface->Open(0, -1);
            visible = modeOnly = true;
            }

Klaus
-- 
_______________________________________________________________

Klaus Schmidinger                       Phone: +49-8635-6989-10
CadSoft Computer GmbH                   Fax:   +49-8635-6989-40
Hofmark 2                               Email:   kls@cadsoft.de
D-84568 Pleiskirchen, Germany           URL:     www.cadsoft.de
_______________________________________________________________