[vdr] Re: patch reccmd submenu for vdr1.2.5

["Christian Jacobsen" <christian.jacobsen@stageholding.de>]

Hallo,

>The patch has been tested on vdrportal.de and the only unresolved problem
>is a 
>compiler warning concerning hidden virtual functions, which I could not 
>reproduce on my system.
>The patch is considered for inclusion in 1.3 (though not confirmed).

I have a problem using this on SuSe 8.0, DVB 1.0.1 and VDR 1.2.5 Vanilla 

Last part of Compile :

g++ -g -O2 -Wall -Woverloaded-virtual -c -DREMOTE_KBD -DREMOTE_LIRC
-DCMD_SU
BMENUS -D_GNU_SOURCE -DVIDEODIR=\"/video\" -DPLUGINDIR=\"./PLUGINS/lib\"
-DV
FAT -I../DVB/include keys.c
g++ -g -O2 -Wall -Woverloaded-virtual -c -DREMOTE_KBD -DREMOTE_LIRC
-DCMD_SU
BMENUS -D_GNU_SOURCE -DVIDEODIR=\"/video\" -DPLUGINDIR=\"./PLUGINS/lib\"
-DV
FAT -I../DVB/include lirc.c
make: *** No rule to make target `dvbsub.h', needed by `menu.o'.  Stop.


I noticed that the version on vdrportal a little bit different is !! (and
that that compiles with a small change.)
So I compared them.

I found these differences :

-  void Add(cListObject *Object, cListObject *After = NULL);
+  virtual void Add(cListObject *Object, cListObject *After = NULL);

and this :

+#include "dvbsub.h"

And the last one is the one "disturbing" ;)

Remove that from menu.c again and it compiles.

It now brings this warning :

g++ -g -O2 -Wall -Woverloaded-virtual -c -DREMOTE_KBD -DREMOTE_
-DCMD_SUBMENUS -D_GNU_SOURCE -DVIDEODIR=\"/video\"
-DPLUGINDIR=\"./PLUGINS/lib\" -I../DVB/include menu.c
menu.c: In method `enum eOSState cMenuCommands::Execute()':
menu.c:1525: warning: unused variable `enum eOSState state'

As I just found this and I don't have any possibility to start VDR here I
can't say if it really works ;)

Greetings
Christian Jacobsen



-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe vdr" as subject.