[vdr] Re: ANNOUNCE: Softdevice plugin. Use /dev/fb for output

[Holger Waechtler <holger@convergence.de>]

Holger Waechtler wrote:
> Hi,
>
> Roland Praml wrote:
>
> > Hello
> >
> > I've uploaded a new version. This one should also compile with gcc 3.2
> > (I hope)
> >
> > http://www.k13zoo.de/vdr/vdr-softdevice-0.0.2.tar.bz2
> >
> > Comments are welcome.
>
> I had only a short look over your code, but there came three things to 
> my mind.
>
> I'm not sure whether your GET_MPEG2_PTS() macro is correct, I'd write it 
> like this:
>
> #define GET_MPEG2_PTS(x)   ( ((uint64_t)x[4]&0xFE) >>1     | \
>                              ((uint64_t)x[3])      <<7     | \
>                              ((uint64_t)x[2]&0xFE) <<14    | \
> -                            ((uint64_t)x[1])      <<22    | \
> +                            ((uint64_t)x[1])      <<21    | \
>                              ((uint64_t)x[0]&0x0E) <<29 )
>
> (x[1] contains PTS[29:21], so you need to shift it 21 bits to the left, 
> not 22 bits)
oops, sorry - the 22 was correct I think.

Holger




--
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe vdr" as subject.