vdr April 2011

vdr@linuxtv.org

38 participants
38 discussions

[Patch] Make RGYB buttons customizeable
by Oliver Schinagl 07 Apr '11

07 Apr '11

Hey all, Ever had the trouble that your remote's color navigation key weren't the same as VDR's? Well I wrote this patch the past 4 hours which lets you configure them. By doing so, the order of the buttons in the menu changes depending on whatever you tell it to. So finally that remote can match whatever is displayed on screen. This only works for the classic and st-tng skins, as those are supplied with VDR. The Skin needs to support this feature. If there is no skin support, the setting simply gets ignored by that skin. Since only the order of the buttons in the skin are being changed any plugin configuration will be independent from this change. What I mean is that, when a plugin has configured blue to take you straight to the photo gallery, the blue button will still do this, no matter where it is on the remote. If the plugin however used the blue key to fast forward, because it is the right most key, and thus made sense logically there, it will no longer when you move the keys around. Practically, this will boil down to a handful of plugins depending on location which imo is a little weird anyway :) Also, I patched it on a Gentoo box using the latest 1.6 ebuild they have so line numbers may be a little off in the patch due to various patches Gentoo may apply. It's the only dev. box for VDR I have so forgive me on that. I'm looking forward to the review :) Oliver

1 0

[Patch] Make RGYB buttons customizeable
by Oliver Schinagl 07 Apr '11

07 Apr '11

6 27

[PATCH] PLUGINS/src/dvbsddevice/dvbsdffosd.c: remove superflous variable `Bitmap`
by Paul Menzel 03 Apr '11

03 Apr '11

Date: Fri, 4 Feb 2011 14:58:23 +0100 Cppcheck reports the following. cppcheck: (style) Variable 'Bitmap' is assigned a value that is never used Therefore remove the variable `Bitmap` for stylistic reasons since the compiler probably optimized that out anyway. Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> CC: Klaus Schmidinger <Klaus.Schmidinger(a)tvdr.de> --- PLUGINS/src/dvbsddevice/dvbsdffosd.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/PLUGINS/src/dvbsddevice/dvbsdffosd.c b/PLUGINS/src/dvbsddevice/dvbsdffosd.c index 4b60ef5..8be1d25 100644 --- a/PLUGINS/src/dvbsddevice/dvbsdffosd.c +++ b/PLUGINS/src/dvbsddevice/dvbsdffosd.c @@ -73,8 +73,7 @@ void cDvbSdFfOsd::SetActive(bool On) Flush(); } else if (shown) { - cBitmap *Bitmap; - for (int i = 0; (Bitmap = GetBitmap(i)) != NULL; i++) { + for (int i = 0; GetBitmap(i) != NULL; i++) { Cmd(OSD_SetWindow, 0, i + 1); Cmd(OSD_Close); } @@ -108,8 +107,7 @@ eOsdError cDvbSdFfOsd::CanHandleAreas(const tArea *Areas, int NumAreas) eOsdError cDvbSdFfOsd::SetAreas(const tArea *Areas, int NumAreas) { if (shown) { - cBitmap *Bitmap; - for (int i = 0; (Bitmap = GetBitmap(i)) != NULL; i++) { + for (int i = 0; GetBitmap(i) != NULL; i++) { Cmd(OSD_SetWindow, 0, i + 1); Cmd(OSD_Close); } -- 1.7.4.1

1 0

[PATCH] PLUGINS/src/osddemo/osddemo.c: fix possible null pointer dereference
by Paul Menzel 03 Apr '11

03 Apr '11

Date: Sun, 3 Apr 2011 22:53:33 +0200 Cppcheck reports the following. $ cppcheck --version Cppcheck 1.47 $ cppcheck . […] Checking ./PLUGINS/src/osddemo/osddemo.c... [./PLUGINS/src/osddemo/osddemo.c:8]: (debug) Include file: "vdr/osd.h" not found. [./PLUGINS/src/osddemo/osddemo.c:9]: (debug) Include file: "vdr/plugin.h" not found. [./PLUGINS/src/osddemo/osddemo.c:270]: (error) Possible null pointer dereference: NextPixmap […] `CreateTextPixmap` can indeed assign `NULL` to `NextPixmap` and right before in line 265 the same check is performed. Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> CC: Klaus Schmidinger <Klaus.Schmidinger(a)tvdr.de> --- PLUGINS/src/osddemo/osddemo.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/PLUGINS/src/osddemo/osddemo.c b/PLUGINS/src/osddemo/osddemo.c index 2e6a33b..d3ec718 100644 --- a/PLUGINS/src/osddemo/osddemo.c +++ b/PLUGINS/src/osddemo/osddemo.c @@ -267,7 +267,9 @@ void cTrueColorDemo::Action(void) } Start = cTimeMs::Now(); StartLine = Line; - Line += NextPixmap->DrawPort().Height(); + if (NextPixmap) { + Line += NextPixmap->DrawPort().Height(); + } } State++; } -- 1.7.4.1

1 0

[ANNOUNCE] VDR developer version 1.7.17
by Klaus Schmidinger 03 Apr '11

03 Apr '11

VDR developer version 1.7.17 is now available at ftp://ftp.tvdr.de/vdr/Developer/vdr-1.7.17.tar.bz2 A 'diff' against the previous version is available at ftp://ftp.tvdr.de/vdr/Developer/vdr-1.7.16-1.7.17.diff WARNING: ======== This is a *developer* version. Even though *I* use it in my productive environment. I strongly recommend that you only use it under controlled conditions and for testing and debugging. This version introduces support for TrueColor OSD. Note, though, that output plugins need to be enhanced in order to support actual TrueColor display (if the device they control can handle TrueColor). Also, skins that want to make use of TrueColor may need to be adapted to the new interface using cPixmap. The changes since version 1.7.16: - Updated the Estonian OSD texts (thanks to Arthur Konovalov). - Fixed following symbolic links in RemoveFileOrDir() (cont'd) (thanks to Steffen Barszus). - Changed the description of cDevice::GetSTC() to make it mandatory for devices that can replay. - Removed the check for positive STC values from cDvbSubtitleConverter::Action(). - Added cString::operator=(const char *String) (suggested by Antti Seppälä). - Some spelling fixes (thanks to Ville Skyttä). - Passing package name and version to xgettext (thanks to Ville Skyttä). - Made 'dist' target dependent on up to date *.po (thanks to Ville Skyttä). - Added Language and fixed Language-Team header of *.po (thanks to Ville Skyttä). - Updated the Lithuanian OSD texts (thanks to Valdemaras Pipiras). - Fixed detecting frames on channels that broadcast with 50 or 60 fps. This avoids artifacts during fast forward/rewind when replaying recordings from such channels. To fix the index of existing recordings from such channels, just delete the 'index' file of the recording and VDR will generate a new one the next time you play it. You should also change the line "F 25" to "F 50" in the 'info' file of that recording. - Added support for "registration descriptor" to 'libsi' and using it in pat.c (thanks to Rolf Ahrenberg). - Fixed unjustified log entries about changed channel pids (reported by Derek Kelly). - Added an include of VDR's 'Make.global' to libsi's Makefile (thanks to Rolf Ahrenberg). - Removed displaying the "contents" information from the "Classic VDR" and "ST:TNG Panels" skins, because it is often wrong and nothing but irritating. - Added typecasts to avoid gcc 4.5 warnings in switch statements on eKeys variables where additional 'k_...' flags are used. - Fixed inclusion of <stdarg.h> (thanks to Henning Heinold). - Changed "frame duration" to "frame rate" in vdr.5 (reported by Tobias Grimm). - Removing a cRemote from the Remotes list in case its initialization failed (thanks to Dominik Strasser). - Added LDFLAGS to the linker calls in the Makefiles (thanks to Joerg Bornkessel and Paul Menzel). - Now updating the 'frames per second' data in the list of recordings when a new recording is started that has a frame rate other than the default. - The include path to the freetype2 header files is now retrieved via a call to 'pkg-config --cflags freetype2' (suggested by Andreas Oberritter). - The OSD now has full TrueColor support. There can be several "pixmaps" that can be overlayed with alpha blending. All existing skins should work out of the box with the TrueColor OSD - the only exception being cOsd::GetBitmap(). Since the TrueColor OSD doesn't use bitmaps, this function will return a dummy bitmap, which may not be what the plugin expects. As long as this bitmap is only used for setting the palette, there is no problem. However, any other operations on this bitmap will have no effect. See the description of the cPixmap functions in osd.h for details about the new functionalities. The "ST:TNG Panels" skin has been enhanced to automatically use the TrueColor OSD if available. The "osddemo" plugin has been extended to show some of the possibilities of the TrueColor OSD if it is run on a system that actually provides TrueColor support. Thanks to Reinhard Nissl for some valuable input, help with debugging, and an implementation of the AlphaBlend() function. - Updated the Slovakian language texts (thanks to Milan Hrala). - Added Serbian language texts (thanks to Milan Cvijanovic). - Fixed reallocating memory in the "pictures" plugin (reported by Paul Menzel, with input from Oliver Endriss). - Fixed reallocating memory in cTsToPes::PutTs() (suggested by Oliver Endriss). - Now checking the result of all realloc() calls. - Fixed setting up the 'Recordings' menu in case there are several recordings with exactly the same name (reported by Marcus Hilbrich). - Setting the audio type of language descriptors to 0x00 in the PAT/PMT generator (thanks to Anssi Hannula). - Changed the compiler optimization flag to -O3, which gives quite a performance boost in the AlphaBlend() function. - While replaying, the editing marks are now updated every 10 seconds (based on a patch from Manuel Reimer). - Now reducing the thread and I/O priority cCuttingThread::Action() to make the foreground process more responsive (suggested by Frank Neumann). - Removed checking for minimum line length of 21 characters in the LIRC receiver code (reported by Gerald Dachs). - Updated the Romanian OSD texts (thanks to Lucian Muresan). - Now storing the original display size when handling DVB subtitles (thanks to Reinhard Nissl). - The original display size of subtitles is now used to scale them properly when displaying them on an HD OSD. Have fun! Klaus

8 22

[Patch] crashes with old recordings without info file
by Mika Laitio 03 Apr '11

03 Apr '11

I have some old recordings made on 2005 which does not have info file. This caused vdr 1.7.17 to crash because in tools.c line 1194 there is no check whether the file parameter passed is NULL or not. Real cause for the crash is in the vdrrip plugins which should handle the case where the info file does not exist on setLengthVDR method on movie.c. Anyway, it's propably good idea also to has the NULL check's in vdr's own code. Patches attached for tools.c and recording.c. #0 0x00007ffff640e8ff in getdelim () from /lib64/libc.so.6 #1 0x00000000004fcd48 in getline (this=0x7fffffffde30, f=0x0) at /usr/include/bits/stdio.h:118 #2 cReadLine::Read (this=0x7fffffffde30, f=0x0) at tools.c:1194 #3 0x00000000004cc383 in cRecordingInfo::Read (this=0xc29bc0, f=0x0) at recording.c:419 #4 0x00007fffef0397a0 in cMovie::setLengthVDR() () from ./PLUGINS/lib/libvdr-vdrrip.so.1.7.17 #5 0x00007fffef03af00 in cMovie::cMovie(char const*, char const*) () from ./PLUGINS/lib/libvdr-vdrrip.so.1.7.17 #6 0x00007fffef0367d7 in cMenuVdrripMovie::cMenuVdrripMovie(char const*, char const*) () from ./PLUGINS/lib/libvdr-vdrrip.so.1.7.17 #7 0x00007fffef03807d in cMenuVdrripEncode::ProcessKey(eKeys) () from ./PLUGINS/lib/libvdr-vdrrip.so.1.7.17 [lamikr@tinka Prisma:_Einstein_ja_kaiken_teoria]$ ls -la 2005-04-21.20\:58.50.99.rec/ total 1338080 drwxr-xr-x 2 76 76 4096 2008-05-17 17:48 ./ drwxr-xr-x 3 76 76 4096 2008-05-17 17:46 ../ -rw-r--r-- 1 76 76 1369418800 2008-05-17 17:48 001.vdr -rw-r--r-- 1 76 76 727968 2008-05-17 17:48 index.vdr -rw-r--r-- 1 76 76 4 2008-05-17 17:48 resume.vdr -rw-r--r-- 1 76 76 441 2008-05-17 17:48 summary.vdr

2 2

vdr <-> vdr-xine <-> xine-lib and vdpau and HD recordings
by Joerg Riechardt 02 Apr '11

02 Apr '11

Hi, I have a problem with skipping during a replay of a HD recording. Running xine --verbose=2 I see after pressing the yellow button (skip +60 sec) lots of video_out: throwing away image with pts xxxxxxx because it's too old (diff : yyyyy) messages. This is for a few seconds or forever, depending on system load, and causes 100% Cpu, and spoils recordings on my slow system. On faster systems you will hardly notice this. If I patch cDvbPlayer::SkipSeconds with - readIndex = Index - 1; // Action() will first increment it! + readIndex = Index; // Index - 1 causes problems in xine I no longer get those „throwing away image“ messages and the Cpu peak is only short and not that high. This happens also for starting a replay and for resuming replay after fast forward, but for those I have no vdr patch. I would very much appreciate if somebody with deeper knowledge of the interplay between vdr <-> vdr-xine <-> xine-lib would look into and comment on this. You find more information at http://www.vdr-portal.de/board16-video-disk-recorder/board85-hdtv-dvb-s2/p9… (german). Without patch the video plugin gets loaded first, the audio plugin second. With patch the video plugin gets loaded second, the audio plugin first. Don´t know if that is important. Joerg

3 8

Re: [vdr] [Patch] Make RGYB buttons customizeable
by Rolf Ahrenberg 02 Apr '11

02 Apr '11

On Fri, 1 Apr 2011, VDR User wrote: > Ignoring remotes that don't follow the RGYB scheme doesn't make them > any less 'tv oriented' or go away. I can't imagine it's much of a > leap to make the colored button position customizable and is probably > something that's better to have then not. What good argument against > allowing the user to customize the layout according to their actual > remote button layout could there be? None that I can think of. I'd > guess Klaus will consider any patches submitted to him which don't > cause problems. Regardless, users always have the option to patch the > feature in if it doesn't become a part of VDR's core. The RGYB color enumeration is defined in the video teletext standard and every TV/STB set implementing the teletext feature DOES use the mentioned color button order. I guess the teletext is used mainly in Europe, so there might be different conventions elsewhere, but the VDR is a STB for DVB standard that documents the teletext too. IMO, you really should switch the OSD button colors in skin plugins instead of patching the core VDR. There will be some glitches with learning the remotes, but these can be fixed with some extra documentation (Press 'Red/leftmost color' button). These remotes with "wrong" color button orders are really a small minority here mainly targeted to some odd mediacenters or PS3 - at least here in the northern Europe. BR, -- rofa

5 4

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

vdr April 2011