Hi
I made a patch to allow special case for instant recordings to only record the present event. This is done by defining Instant rec. time to 0.
There is still the question what should be done if event is non-existent or otherwise not obtained? Should the VDR default Instant rec. time be used or not?
On 20.05.2012 11:30, Matti Lehtimäki wrote:
Hi
I made a patch to allow special case for instant recordings to only record the present event. This is done by defining Instant rec. time to 0.
Nice idea. However, please also take VPS into account. If Setup.UseVps is set, and the event has a VPS time, the timer's start time should be set to the VPS time, and the timer's ttVps flag should be set.
Klaus
On 05/20/2012 12:37 PM, Klaus Schmidinger wrote:
Nice idea. However, please also take VPS into account. If Setup.UseVps is set, and the event has a VPS time, the timer's start time should be set to the VPS time, and the timer's ttVps flag should be set.
Hi
Attached is a new version of the patch with support for VPS. I also changed the behavior of the patch in case no event is found so that recording will succeed even in that situation. In previous version of patch the recording length would have been zero but now it becomes VDR default Instant rec. time (180 min) if no event is obtained.
On 20.05.2012 13:09, Matti Lehtimäki wrote:
On 05/20/2012 12:37 PM, Klaus Schmidinger wrote:
Nice idea. However, please also take VPS into account. If Setup.UseVps is set, and the event has a VPS time, the timer's start time should be set to the VPS time, and the timer's ttVps flag should be set.
Hi
Attached is a new version of the patch with support for VPS. I also changed the behavior of the patch in case no event is found so that recording will succeed even in that situation. In previous version of patch the recording length would have been zero but now it becomes VDR default Instant rec. time (180 min) if no event is obtained.
One more thing comes to mind: you also need to make sure that the 'day' is set to the day of the EPG event. Just in case it is past midnight already and the event started "yesterday" ;-)
Klaus
On 05/20/2012 02:15 PM, Klaus Schmidinger wrote:
One more thing comes to mind: you also need to make sure that the 'day' is set to the day of the EPG event. Just in case it is past midnight already and the event started "yesterday" ;-)
Indeed that was missing. I think setting the day is relevant only if VPS is used since in otherwise the start time is the current time not the start time of the event. Or should the start time be set to that of the event if VPS is not used?
On 20.05.2012 13:41, Matti Lehtimäki wrote:
On 05/20/2012 02:15 PM, Klaus Schmidinger wrote:
One more thing comes to mind: you also need to make sure that the 'day' is set to the day of the EPG event. Just in case it is past midnight already and the event started "yesterday" ;-)
Indeed that was missing. I think setting the day is relevant only if VPS is used since in otherwise the start time is the current time not the start time of the event. Or should the start time be set to that of the event if VPS is not used?
Well, that's a matter of taste. For VPS it is relevant, otherwise it's up to you.
Klaus
On 05/20/2012 02:45 PM, Klaus Schmidinger wrote:
On 20.05.2012 13:41, Matti Lehtimäki wrote:
On 05/20/2012 02:15 PM, Klaus Schmidinger wrote:
One more thing comes to mind: you also need to make sure that the 'day' is set to the day of the EPG event. Just in case it is past midnight already and the event started "yesterday" ;-)
Indeed that was missing. I think setting the day is relevant only if VPS is used since in otherwise the start time is the current time not the start time of the event. Or should the start time be set to that of the event if VPS is not used?
Well, that's a matter of taste. For VPS it is relevant, otherwise it's up to you.
Attached is a new version of the patch with correct day always set when VPS is used. Could this patch be included in next version of VDR?
On 20.05.2012 13:55, Matti Lehtimäki wrote:
On 05/20/2012 02:45 PM, Klaus Schmidinger wrote:
On 20.05.2012 13:41, Matti Lehtimäki wrote:
On 05/20/2012 02:15 PM, Klaus Schmidinger wrote:
One more thing comes to mind: you also need to make sure that the 'day' is set to the day of the EPG event. Just in case it is past midnight already and the event started "yesterday" ;-)
Indeed that was missing. I think setting the day is relevant only if VPS is used since in otherwise the start time is the current time not the start time of the event. Or should the start time be set to that of the event if VPS is not used?
Well, that's a matter of taste. For VPS it is relevant, otherwise it's up to you.
Attached is a new version of the patch with correct day always set when VPS is used. Could this patch be included in next version of VDR?
I guess so...
Klaus
On 20.05.2012 13:55, Matti Lehtimäki wrote:
On 05/20/2012 02:45 PM, Klaus Schmidinger wrote:
On 20.05.2012 13:41, Matti Lehtimäki wrote:
On 05/20/2012 02:15 PM, Klaus Schmidinger wrote:
One more thing comes to mind: you also need to make sure that the 'day' is set to the day of the EPG event. Just in case it is past midnight already and the event started "yesterday" ;-)
Indeed that was missing. I think setting the day is relevant only if VPS is used since in otherwise the start time is the current time not the start time of the event. Or should the start time be set to that of the event if VPS is not used?
Well, that's a matter of taste. For VPS it is relevant, otherwise it's up to you.
Attached is a new version of the patch with correct day always set when VPS is used. Could this patch be included in next version of VDR?
While adopting this patch I found that we need to set the timer's 'event' pointer to the actual event here, and that the start time should always be set to the event's start time (even if VPS is not used) in order to keep the event from getting reassigned to a different one later on.
I have attached a revised version of your patch (against VDR 1.7.30). Please take a look and let me know whether it is still OK for you.
Klaus
On 09/15/2012 04:57 PM, Klaus Schmidinger wrote:
While adopting this patch I found that we need to set the timer's 'event' pointer to the actual event here, and that the start time should always be set to the event's start time (even if VPS is not used) in order to keep the event from getting reassigned to a different one later on.
I have attached a revised version of your patch (against VDR 1.7.30). Please take a look and let me know whether it is still OK for you.
The revised version of the patch works the way I want so it's OK for me. Thanks.
-
Klaus Schmidinger -
Matti Lehtimäki