[linux-dvb] patch - descrambling on stream level
Manu Abraham
abraham.manu at gmail.com
Thu Oct 20 11:31:32 CEST 2005
Philip Prindeville wrote:
>
> Sign me up... I might even have some patches to send in...
>
>
Sure, you are more than welcome to do so. Please do have some
coordination with Henrik too on that, since he has taken a go at it.
>>>> In:
>>>>
>>>> + p_descriptor->short_event.iso_639_language_code =
>>>> + (((buf[pos] << 8) | buf[pos + 1]) << 8) | buf[pos +
>>>> 2];
>>>>
>>>>
>>>> Not sure I get this... Shouldn't "pos" be shifted more bits?
>>>> Otherwise,
>>>> "pos" and "pos + 1" will be combined... Oh, got it. Didn't match
>>>> parens.
>>>> Well, I'd still write:
>>>>
>>>> (buf[pos] << 16) | (buf[pos + 1] << 8) | buf[pos + 2];
>>>>
>>>> instead...
>>>>
>>>
>>
>> I would too ;) Also in descriptor.c. I wanted to change as few things as
>> possible when I had no chance of testing it.
>>
>>
>
> Sound strategy. Patches should either be (a) new functionality, (b)
> bug fixes,
> or (c) code clean-up and restructuring... but only one of the above
> at a time.
> Otherwise, you risk introducing new bugs that are harder to track down.
>
Right..
Manu
More information about the linux-dvb
mailing list